Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 10382082: Disable the compile option 'mlong-calls' for Android for IA (Closed)

Created:
8 years, 7 months ago by yongsheng
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Disable the compile option 'mlong-calls' for Android for IA This is because this option is a ARM-only option. See the documentation here: http://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html BUG=127379 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yongsheng
Mark and Nico, could you please help review this patch? Thanks
8 years, 7 months ago (2012-05-10 01:31:47 UTC) #1
Nico
LGTM (When doing changes, don't just say "Do X" in CL descriptions / bugs, also ...
8 years, 7 months ago (2012-05-10 02:30:06 UTC) #2
yongsheng
On 2012/05/10 02:30:06, Nico wrote: > LGTM > > (When doing changes, don't just say ...
8 years, 7 months ago (2012-05-10 02:49:32 UTC) #3
Nico
On 2012/05/10 02:49:32, yongsheng.zhu wrote: > On 2012/05/10 02:30:06, Nico wrote: > > LGTM > ...
8 years, 7 months ago (2012-05-10 02:55:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10382082/1
8 years, 7 months ago (2012-05-10 03:01:03 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 05:40:52 UTC) #6
Change committed as 136247

Powered by Google App Engine
This is Rietveld 408576698