Update all GAIA URLs to accounts.google.com/... from www.google.com/accounts/...

Update GAIA URL to accounts.google.com/... from www.google.com/accounts/...

BUG=127147
TEST=all serivices dependent on GAIA auth should still work (sync, login, policy, drive...)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136345

[Jamie, 2012-05-09 01:24:48]

remoting lgtm.

https://chromiumcodereview.appspot.com/10382077/diff/1/remoting/webapp/manife...
File remoting/webapp/manifest.json (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/remoting/webapp/manife...
remoting/webapp/manifest.json:26: "https://www.google.com/accounts/*",
You can get rid of this line as well.

[sail, 2012-05-09 01:31:43]

sync_promo/* LGTM!
+munjal incase he has any suggestions

[xiyuan, 2012-05-09 01:39:16]

LGTM

When run trybots, make sure sync_integration_tests and cros_x86 are tested.

[Nirnimesh, 2012-05-09 02:18:21]

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/test/functional...
File chrome/test/functional/passwords.py (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/test/functional...
chrome/test/functional/passwords.py:18: URL =
'https://accounts.www.google.com/ServiceLogin'
remove www

[Albert Bodenhamer, 2012-05-09 03:13:16]

lgtm

[Nikita (slow), 2012-05-09 06:00:10]

chromeos/login lgtm

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/login/existing_user_controller.cc:95:
"https://accounts.google.com/NewAccount?service=mail";
This could be as well updated to
https://accounts.google.com/SignUp?service=mail

as NewAccount redirects to it and new URLs use "SignUp" endpoint.

[Mattias Nissler (ping if slow), 2012-05-09 07:45:03]

LGTM. Let's hope everything works out as intended.

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/printin...
File chrome/browser/printing/cloud_print/cloud_print_setup_source.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/printin...
chrome/browser/printing/cloud_print/cloud_print_setup_source.cc:28:
"https://accounts.google.com/NewAccount?service=chromiumsync";
If you change the other NewAccount URL to SignUp, then you should probably
change this instance as well.

[zel, 2012-05-09 16:35:04]

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/printin...
File chrome/browser/printing/cloud_print/cloud_print_setup_source.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/printin...
chrome/browser/printing/cloud_print/cloud_print_setup_source.cc:28:
"https://accounts.google.com/NewAccount?service=chromiumsync";
On 2012/05/09 07:45:04, Mattias Nissler wrote:
> If you change the other NewAccount URL to SignUp, then you should probably
> change this instance as well.

Not sure about that, the UI for /SignUp and /NewAccount look very different. I
would leave this decision to authors of these files.

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/test/functional...
File chrome/test/functional/passwords.py (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/test/functional...
chrome/test/functional/passwords.py:18: URL =
'https://accounts.www.google.com/ServiceLogin'
On 2012/05/09 02:18:22, Nirnimesh wrote:
> remove www

Done.

https://chromiumcodereview.appspot.com/10382077/diff/1/remoting/webapp/manife...
File remoting/webapp/manifest.json (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/remoting/webapp/manife...
remoting/webapp/manifest.json:26: "https://www.google.com/accounts/*",
On 2012/05/09 01:24:49, Jamie wrote:
> You can get rid of this line as well.

Done.

[Ben Goodger (Google), 2012-05-09 17:38:44]

LGTM

[tim (not reviewing), 2012-05-09 17:47:58]

LGTM w/ small favor! +rsimha

https://chromiumcodereview.appspot.com/10382077/diff/7005/chrome/browser/sync...
File chrome/browser/sync/test/integration/sync_test.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/7005/chrome/browser/sync...
chrome/browser/sync/test/integration/sync_test.cc:66: const char
kClientLoginUrl[] = "https://accounts.google.com/ClientLogin";
Could you add a "TODO(rsimha): Use GaiaUrls here."  We shouldn't have these
separate values.

[tim (not reviewing), 2012-05-09 17:48:27]

On 2012/05/09 17:47:58, timsteele wrote:
> LGTM w/ small favor! +rsimha
> 
>
https://chromiumcodereview.appspot.com/10382077/diff/7005/chrome/browser/sync...
> File chrome/browser/sync/test/integration/sync_test.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10382077/diff/7005/chrome/browser/sync...
> chrome/browser/sync/test/integration/sync_test.cc:66: const char
> kClientLoginUrl[] = "https://accounts.google.com/ClientLogin";
> Could you add a "TODO(rsimha): Use GaiaUrls here."  We shouldn't have these
> separate values.

(L G T M was for browser/sync/)

[zel, 2012-05-09 17:52:49]

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/login/existing_user_controller.cc:95:
"https://accounts.google.com/NewAccount?service=mail";
On 2012/05/09 06:00:12, Nikita Kostylev wrote:
> This could be as well updated to
> https://accounts.google.com/SignUp?service=mail
> 
> as NewAccount redirects to it and new URLs use "SignUp" endpoint.

Hmm, .../NewAccount?service=mail does indeed redirect to /SignUp, while
.../NewAccount?service=chromiumsync doesn't. I will leave this change up to
owners of the corresponding code that deal with new account creation.

https://chromiumcodereview.appspot.com/10382077/diff/7005/chrome/browser/sync...
File chrome/browser/sync/test/integration/sync_test.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/7005/chrome/browser/sync...
chrome/browser/sync/test/integration/sync_test.cc:66: const char
kClientLoginUrl[] = "https://accounts.google.com/ClientLogin";
On 2012/05/09 17:47:59, timsteele wrote:
> Could you add a "TODO(rsimha): Use GaiaUrls here."  We shouldn't have these
> separate values.

Done.

[willchan no longer on Chromium, 2012-05-10 01:07:32]

Sorry, I'll review this tonight or tomorrow morning. Busy day catching up
on email :(

On Tue, May 8, 2012 at 6:01 PM, <zelidrag@chromium.org> wrote:

> Reviewers: willchan, Ben Goodger (Google), timsteele, sail, awong, Albert
> Bodenhamer, xiyuan, Mattias Nissler,
>
> Description:
> Update GAIA URL to accounts.google.com/... from www.google.com/accounts/.
> ..
>
> BUG=127147
> TEST=all serivices dependent on GAIA auth should still work (sync, login,
> policy, drive...)
>
> Please review this at
https://chromiumcodereview.**appspot.com/10382077/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/app/resources/locale_**settings.grd
>  M chrome/app/resources/terms/**chromeos/terms_en.html
>  M chrome/app/resources/terms/**terms_am.html
>  M chrome/app/resources/terms/**terms_bn.html
>  M chrome/app/resources/terms/**terms_sw.html
>  M chrome/browser/chromeos/login/**existing_user_controller.cc
>  M chrome/browser/chromeos/login/**mock_url_fetchers.cc
>  M chrome/browser/chromeos/login/**online_attempt_unittest.cc
>  M chrome/browser/importer/**importer_host.cc
>  M chrome/browser/net/browser_**url_util.h
>  M chrome/browser/net/browser_**url_util.cc
>  M chrome/browser/net/browser_**url_util_unittest.cc
>  M chrome/browser/net/gaia/gaia_**oauth_fetcher.cc
>  M chrome/browser/password_**manager/login_database_**unittest.cc
>  M chrome/browser/printing/cloud_**print/cloud_print_setup_**source.cc
>  M chrome/browser/printing/cloud_**print/cloud_print_url.cc
>  M chrome/browser/resources/**chromeos/gaia_auth/manifest_**test.json
>  M chrome/browser/sync/resources/**gaia_login_test.html
>  M chrome/browser/sync/test/**integration/sync_test.cc
>  M chrome/browser/ui/webui/sync_**promo/sync_promo_ui.cc
>  M chrome/common/net/gaia/gaia_**auth_fetcher_unittest.cc
>  M chrome/common/net/gaia/gaia_**authenticator.h
>  M chrome/common/net/gaia/gaia_**urls.h
>  M chrome/common/net/gaia/gaia_**urls.cc
>  M chrome/common/net/gaia/google_**service_auth_error.h
>  M chrome/common/net/gaia/oauth_**request_signer_unittest.cc
>  M chrome/common/url_constants.cc
>  M chrome/test/data/autofill/**heuristics/input/09_register_**
> google.com.html
>  M chrome/test/data/google/**google.html
>  M chrome/test/functional/**passwords.py
>  M chrome/test/functional/test_**utils.py
>  M remoting/webapp/manifest.json
>
>
>

[willchan no longer on Chromium, 2012-05-10 16:10:19]

chrome/common/net/ LGTM. Had a minor question is all.

https://chromiumcodereview.appspot.com/10382077/diff/1034/chrome/common/net/u...
File chrome/common/net/url_util.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1034/chrome/common/net/u...
chrome/common/net/url_util.cc:106: net::UnescapeRule::SPACES |
net::UnescapeRule::URL_SPECIAL_CHARS);
I don't know the actual form of the URL you are applying this too, but you're
sure you have the right unescape rules, right? Do you want
REPLACE_PLUS_WITH_SPACE? Just checking.

[xiyuan, 2012-05-10 16:54:00]

https://chromiumcodereview.appspot.com/10382077/diff/1034/chrome/common/net/u...
File chrome/common/net/url_util.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1034/chrome/common/net/u...
chrome/common/net/url_util.cc:106: net::UnescapeRule::SPACES |
net::UnescapeRule::URL_SPECIAL_CHARS);
On 2012/05/10 16:10:21, willchan wrote:
> I don't know the actual form of the URL you are applying this too, but you're
> sure you have the right unescape rules, right? Do you want
> REPLACE_PLUS_WITH_SPACE? Just checking.

This CL uses this function to decode Gaia redirect URL which does not contain
"+" as far as I could tell. However, since this function is in common util file,
think we probably want to add REPLACE_PLUS_WITH_SPACE as wtc sugggested.

[tfarina, 2012-05-10 17:05:18]

On Thu, May 10, 2012 at 1:54 PM,  <xiyuan@chromium.org> wrote:
> This CL uses this function to decode Gaia redirect URL which does not
> contain "+" as far as I could tell. However, since this function is in
> common util file, think we probably want to add REPLACE_PLUS_WITH_SPACE
> as wtc sugggested.
>
Not wtc, but willchan :)

-- 
Thiago

[zel, 2012-05-10 18:53:55]

https://chromiumcodereview.appspot.com/10382077/diff/1034/chrome/common/net/u...
File chrome/common/net/url_util.cc (right):

https://chromiumcodereview.appspot.com/10382077/diff/1034/chrome/common/net/u...
chrome/common/net/url_util.cc:106: net::UnescapeRule::SPACES |
net::UnescapeRule::URL_SPECIAL_CHARS);
On 2012/05/10 16:54:02, xiyuan wrote:
> On 2012/05/10 16:10:21, willchan wrote:
> > I don't know the actual form of the URL you are applying this too, but
you're
> > sure you have the right unescape rules, right? Do you want
> > REPLACE_PLUS_WITH_SPACE? Just checking.
> 
> This CL uses this function to decode Gaia redirect URL which does not contain
> "+" as far as I could tell. However, since this function is in common util
file,
> think we probably want to add REPLACE_PLUS_WITH_SPACE as wtc sugggested.

Done.