Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 10382068: mac: Don't use -Werror on third-party code in official builds. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Don't use -Werror on third-party code in official builds. BUG=none TEST=official builders go green Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
The -Werror change broke the official builders :-/
8 years, 7 months ago (2012-05-08 19:38:41 UTC) #1
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-08 19:39:26 UTC) #2
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 19:40:26 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698