Quote CppBoundClass/CppVariant in namespace.

Quote CppBoundClass/CppVariant in namespace.

To avoid name conflict when linking DumpRenderTree which has its own implementation of the classes with the same names.
Eventually the related classes will be replaced with V8 API.

BUG=127238
TEST=Build all without error
TBR=ben@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136112

[tony, 2012-05-08 17:27:39]

http://codereview.chromium.org/10382059/diff/3002/webkit/glue/cpp_bound_class.h
File webkit/glue/cpp_bound_class.h (right):

http://codereview.chromium.org/10382059/diff/3002/webkit/glue/cpp_bound_class...
webkit/glue/cpp_bound_class.h:150: using webkit_glue::CppBoundClass;
Please just fix all the callers.  There aren't that many.  You could split this
into two changes (one per .h file) if you wanted to reduce the size of the diff,
but this is simple enough that one change is fine.

[Xianzhu, 2012-05-08 19:38:02]

http://codereview.chromium.org/10382059/diff/3002/webkit/glue/cpp_bound_class.h
File webkit/glue/cpp_bound_class.h (right):

http://codereview.chromium.org/10382059/diff/3002/webkit/glue/cpp_bound_class...
webkit/glue/cpp_bound_class.h:150: using webkit_glue::CppBoundClass;
On 2012/05/08 17:27:39, tony wrote:
> Please just fix all the callers.  There aren't that many.  You could split
this
> into two changes (one per .h file) if you wanted to reduce the size of the
diff,
> but this is simple enough that one change is fine.

Done.

[tony, 2012-05-08 20:52:26]

LGTM, thanks!

http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_binding_ex...
File webkit/glue/cpp_binding_example.cc (right):

http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_binding_ex...
webkit/glue/cpp_binding_example.cc:13: namespace webkit_glue {
Nit: Please move this after the anonymous namespace.

http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_bound_clas...
File webkit/glue/cpp_bound_class.cc (right):

http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_bound_clas...
webkit/glue/cpp_bound_class.cc:27: namespace webkit_glue {
Nit: Please move this after the anonymous namespace.

[Xianzhu, 2012-05-09 16:38:23]

http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_binding_ex...
File webkit/glue/cpp_binding_example.cc (right):

http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_binding_ex...
webkit/glue/cpp_binding_example.cc:13: namespace webkit_glue {
On 2012/05/08 20:52:26, tony wrote:
> Nit: Please move this after the anonymous namespace.

I put it here to avoid webkit_glue:: prefixes in the anonymous namespace block.
Is there any drawback to place anonymous namespace inside of a named namespace?

[tony, 2012-05-09 17:22:44]

On 2012/05/09 16:38:23, Xianzhu wrote:
>
http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_binding_ex...
> File webkit/glue/cpp_binding_example.cc (right):
> 
>
http://codereview.chromium.org/10382059/diff/12002/webkit/glue/cpp_binding_ex...
> webkit/glue/cpp_binding_example.cc:13: namespace webkit_glue {
> On 2012/05/08 20:52:26, tony wrote:
> > Nit: Please move this after the anonymous namespace.
> 
> I put it here to avoid webkit_glue:: prefixes in the anonymous namespace
block.
> Is there any drawback to place anonymous namespace inside of a named
namespace?

Oh, I see. That's OK then.  You could also do a using webkit_glue::Foo.  *shrug*

[commit-bot: I haz the power, 2012-05-09 17:26:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10382059/12002

[commit-bot: I haz the power, 2012-05-09 20:26:18]

Change committed as 136112