Cleanup Javascript Style Violations for chrome://omnibox/

chrome/browser/resources/omnibox/omnibox.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for omnibox.html, served from chrome://omnibox/
  * This is used to debug omnibox ranking.  The user enters some text
  * into a box, submits it, and then sees lots of debug information
  * from the autocompleter that shows what omnibox would do with that
  * input.
  *
  * The simple object defined in this javascript file listens for
  * certain events on omnibox.html, sends (when appropriate) the
  * input text to C++ code to start the omnibox autcomplete controller
  * working, and listens from callbacks from the C++ code saying that
  * results are available.  When results (possibly intermediate ones)
  * are available, the Javascript formats them and displays them.
  */
 cr.define('omniboxDebug', function() {
   'use strict';
 
   /**
    * Register our event handlers.
    */
   function initialize() {
-    document.getElementById('omnibox-input-form').addEventListener(
+    $('omnibox-input-form').addEventListener(
         'submit', startOmniboxQuery, false);
-    document.getElementById('show-details').addEventListener(
-        'change', refresh);
-    document.getElementById('show-incomplete-results').addEventListener(
-        'change', refresh);
-    document.getElementById('show-all-providers').addEventListener(
-        'change', refresh);
+    $('show-details').addEventListener('change', refresh);
+    $('show-incomplete-results').addEventListener('change', refresh);
+    $('show-all-providers').addEventListener('change', refresh);
   }
 
   /**
    * @type {Array.<Object>} an array of all autocomplete results we've seen
    *     for this query.  We append to this list once for every call to
    *     handleNewAutocompleteResult.  For details on the structure of
    *     the object inside, see the comments by addResultToOutput.
    */
   var progressiveAutocompleteResults = [];
 
   /**
    * Extracts the input text from the text field and sends it to the
    * C++ portion of chrome to handle.  The C++ code will iteratively
    * call handleNewAutocompleteResult as results come in.
    */
   function startOmniboxQuery(event) {
     // First, clear the results of past calls (if any).
     progressiveAutocompleteResults = [];
     // Then, call chrome with a one-element list: the value in the text box.
-    chrome.send('startOmniboxQuery',
-                [document.getElementById('input-text').value]);
+    chrome.send('startOmniboxQuery', [$('input-text').value]);
     // Cancel the submit action.  i.e., don't submit the form.  (We handle
     // display the results solely with Javascript.)
     event.preventDefault();
   }
 
   /**
    * Returns a simple object with information about how to display an
    * autocomplete result data field.
    * @param {string} header the label for the top of the column/table.
    * @param {string} urlLabelForHeader the URL that the header should point
@@ skipping 45 matching lines @@
   ];
 
   /**
    * Returns an HTML Element of type table row that contains the
    * headers we'll use for labeling the columns.  If we're in
    * detailed_mode, we use all the headers.  If not, we only use ones
    * marked displayAlways.
    */
   function createAutocompleteResultTableHeader() {
     var row = document.createElement('tr');
-    var inDetailedMode = document.getElementById('show-details').checked;
+    var inDetailedMode = $('show-details').checked;
     for (var i = 0; i < PROPERTY_OUTPUT_ORDER.length; i++) {
       if (inDetailedMode || PROPERTY_OUTPUT_ORDER[i].displayAlways) {
         var headerCell = document.createElement('th');
         if (PROPERTY_OUTPUT_ORDER[i].urlLabelForHeader != '') {
           // Wrap header text in URL.
           var linkNode = document.createElement('a');
           linkNode.href = PROPERTY_OUTPUT_ORDER[i].urlLabelForHeader;
           linkNode.textContent = PROPERTY_OUTPUT_ORDER[i].header;
           headerCell.appendChild(linkNode);
         } else {
@@ skipping 84 matching lines @@
    *     }
    *     ...
    *   }
    * }
    * }
    * </pre>
    * For more information on how the result is packed, see the
    * corresponding code in chrome/browser/ui/webui/omnibox_ui.cc
    */
   function addResultToOutput(result) {
-    var output = document.getElementById('omnibox-debug-text');
-    var inDetailedMode = document.getElementById('show-details').checked;
-    var showIncompleteResults =
-        document.getElementById('show-incomplete-results').checked;
-    var showPerProviderResults =
-        document.getElementById('show-all-providers').checked;
+    var output = $('omnibox-debug-text');
+    var inDetailedMode = $('show-details').checked;
+    var showIncompleteResults = $('show-incomplete-results').checked;
+    var showPerProviderResults = $('show-all-providers').checked;
 
     // Output the result-level features in detailed mode and in
     // show incomplete results mode.  We do the latter because without
     // these result-level features, one can't make sense of each
     // batch of results.
     if (inDetailedMode || showIncompleteResults) {
       var p1 = document.createElement('p');
       p1.textContent = 'elapsed time = ' +
           result.time_since_omnibox_started_ms + 'ms';
       output.appendChild(p1);
@@ skipping 24 matching lines @@
 
   /**
    * @param {Object} result either the combined_results component of
    *     the structure described in the comment by addResultToOutput()
    *     above or one of the per-provider results in the structure.
    *     (Both have the same format.)
    * @return {HTMLTableCellElement} that is a user-readable HTML
    *     representation of this object.
    */
   function addResultTableToOutput(result) {
-    var inDetailedMode = document.getElementById('show-details').checked;
+    var inDetailedMode = $('show-details').checked;
     // Create a table to hold all the autocomplete items.
     var table = document.createElement('table');
     table.className = 'autocomplete-results-table';
     table.appendChild(createAutocompleteResultTableHeader());
     // Loop over every autocomplete item and add it as a row in the table.
     for (var i = 0; i < result.num_items; i++) {
       var autocompleteSuggestion = result['item_' + i];
       var row = document.createElement('tr');
       // Loop over all the columns/properties and output either them
       // all (if we're in detailed mode) or only the ones marked displayAlways.
@@ skipping 31 matching lines @@
   }
 
   /* Repaints the page based on the contents of the array
    * progressiveAutocompleteResults, which represents consecutive
    * autocomplete results.  We only display the last (most recent)
    * entry unless we're asked to display incomplete results.  For an
    * example of the output, play with chrome://omnibox/
    */
   function refresh() {
     // Erase whatever is currently being displayed.
-    var output = document.getElementById('omnibox-debug-text');
+    var output = $('omnibox-debug-text');
     output.innerHTML = '';
 
     if (progressiveAutocompleteResults.length > 0) {  // if we have results
       // Display the results.
-      var showIncompleteResults =
-          document.getElementById('show-incomplete-results').checked;
+      var showIncompleteResults = $('show-incomplete-results').checked;
       var startIndex = showIncompleteResults ? 0 :
           progressiveAutocompleteResults.length - 1;
       for (var i = startIndex; i < progressiveAutocompleteResults.length; i++) {
         addResultToOutput(progressiveAutocompleteResults[i]);
       }
     }
   }
 
   return {
     initialize: initialize,
     startOmniboxQuery: startOmniboxQuery,
     handleNewAutocompleteResult: handleNewAutocompleteResult
   };
 });
 
 document.addEventListener('DOMContentLoaded', omniboxDebug.initialize);