Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10382057: Cleanup Javascript Style Violations for chrome://omnibox/ (Closed)

Created:
8 years, 7 months ago by Mark P
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup Javascript Style Violations for chrome://omnibox/ Precisely, switch getElementById() to $() BUG= TEST=by hand, things still seem to work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/browser/resources/omnibox/omnibox.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/omnibox/omnibox.js View 6 chunks +13 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Mark P
Arv, You should be able to easily rubber-stamp this. --mark
8 years, 7 months ago (2012-05-08 15:46:02 UTC) #1
arv (Not doing code reviews)
LGTM
8 years, 7 months ago (2012-05-08 16:18:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/10382057/1
8 years, 7 months ago (2012-05-08 16:25:48 UTC) #3
commit-bot: I haz the power
Try job failure for 10382057-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=10530 Step "update" is always ...
8 years, 7 months ago (2012-05-08 16:53:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/10382057/1
8 years, 7 months ago (2012-05-08 17:44:18 UTC) #5
commit-bot: I haz the power
Try job failure for 10382057-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 7 months ago (2012-05-08 23:38:40 UTC) #6
Mark P
On 2012/05/08 23:38:40, I haz the power (commit-bot) wrote: > Try job failure for 10382057-1 ...
8 years, 7 months ago (2012-05-09 00:51:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/10382057/1
8 years, 7 months ago (2012-05-09 00:51:51 UTC) #8
commit-bot: I haz the power
Try job failure for 10382057-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=10690 Step "update" is always ...
8 years, 7 months ago (2012-05-09 00:57:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/10382057/1
8 years, 7 months ago (2012-05-09 01:22:19 UTC) #10
commit-bot: I haz the power
Try job failure for 10382057-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 7 months ago (2012-05-09 05:23:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/10382057/1
8 years, 7 months ago (2012-05-09 12:11:04 UTC) #12
commit-bot: I haz the power
Try job failure for 10382057-1 (retry) on win for step "update". It's a second try, ...
8 years, 7 months ago (2012-05-09 12:37:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/10382057/1
8 years, 7 months ago (2012-05-09 12:44:10 UTC) #14
commit-bot: I haz the power
Try job failure for 10382057-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-09 15:07:11 UTC) #15
Mark P
8 years, 7 months ago (2012-05-09 15:13:37 UTC) #16
On 2012/05/09 15:07:11, I haz the power (commit-bot) wrote:
> Try job failure for 10382057-1 (retry) on win_rel for step "browser_tests".
> It's a second try, previously, step "browser_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

F-ing commit queue.

I'll land this manually.

-m

Powered by Google App Engine
This is Rietveld 408576698