Array index computation dehoisting.

src/ia32/lithium-ia32.cc

Index: src/ia32/lithium-ia32.cc
diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc
index 5adaf431bd702ff88a4565897b4698949d3a7736..56527df0b52ac98e509a8096bd002ea1627105d7 100644
--- a/src/ia32/lithium-ia32.cc
+++ b/src/ia32/lithium-ia32.cc
@@ -1958,7 +1958,10 @@ LInstruction* LChunkBuilder::DoLoadKeyedFastElement(
   ASSERT(instr->key()->representation().IsInteger32());
   LOperand* obj = UseRegisterAtStart(instr->object());
   LOperand* key = UseRegisterOrConstantAtStart(instr->key());
-  LLoadKeyedFastElement* result = new(zone()) LLoadKeyedFastElement(obj, key);
+  LLoadKeyedFastElement* result =
+      new(zone()) LLoadKeyedFastElement(obj,
+                                        key,
+                                        instr->index_offset());

[Jakob Kummerow, 2012/05/08 13:46:26]

Again, I think you don't need any of the changes to this file.

[Massi, 2012/05/14 13:48:52]

Well, I decided to add an accessor just for convenience (like in the other
Lithium files)...

   if (instr->RequiresHoleCheck()) AssignEnvironment(result);
   return DefineAsRegister(result);
 }
@@ -1971,7 +1974,9 @@ LInstruction* LChunkBuilder::DoLoadKeyedFastDoubleElement(
   LOperand* elements = UseRegisterAtStart(instr->elements());
   LOperand* key = UseRegisterOrConstantAtStart(instr->key());
   LLoadKeyedFastDoubleElement* result =
-      new(zone()) LLoadKeyedFastDoubleElement(elements, key);
+      new(zone()) LLoadKeyedFastDoubleElement(elements,
+                                              key,
+                                              instr->index_offset());
   return AssignEnvironment(DefineAsRegister(result));
 }
 
@@ -1991,7 +1996,8 @@ LInstruction* LChunkBuilder::DoLoadKeyedSpecializedArrayElement(
   LOperand* key = UseRegisterOrConstant(instr->key());
   LLoadKeyedSpecializedArrayElement* result =
       new(zone()) LLoadKeyedSpecializedArrayElement(external_pointer,
-                                            key);
+                                                    key,
+                                                    instr->index_offset());
   LInstruction* load_instr = DefineAsRegister(result);
   // An unsigned int array load might overflow and cause a deopt, make sure it
   // has an environment.
@@ -2026,7 +2032,10 @@ LInstruction* LChunkBuilder::DoStoreKeyedFastElement(
   LOperand* key = needs_write_barrier
       ? UseTempRegister(instr->key())
       : UseRegisterOrConstantAtStart(instr->key());
-  return new(zone()) LStoreKeyedFastElement(obj, key, val);
+  return new(zone()) LStoreKeyedFastElement(obj,
+                                            key,
+                                            val,
+                                            instr->index_offset());
 }
 
 
@@ -2040,7 +2049,10 @@ LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement(
   LOperand* val = UseTempRegister(instr->value());
   LOperand* key = UseRegisterOrConstantAtStart(instr->key());
 
-  return new(zone()) LStoreKeyedFastDoubleElement(elements, key, val);
+  return new(zone()) LStoreKeyedFastDoubleElement(elements,
+                                                  key,
+                                                  val,
+                                                  instr->index_offset());
 }
 
 
@@ -2071,7 +2083,8 @@ LInstruction* LChunkBuilder::DoStoreKeyedSpecializedArrayElement(
 
   return new(zone()) LStoreKeyedSpecializedArrayElement(external_pointer,
                                                         key,
-                                                        val);
+                                                        val,
+                                                        instr->index_offset());
 }