Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 10382055: Array index computation dehoisting. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified expression. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/x64/lithium-codegen-x64.cc ('K') | « src/x64/lithium-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1945 matching lines...) Expand 10 before | Expand all | Expand 10 after
1956 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement( 1956 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement(
1957 HStoreKeyedFastDoubleElement* instr) { 1957 HStoreKeyedFastDoubleElement* instr) {
1958 ASSERT(instr->value()->representation().IsDouble()); 1958 ASSERT(instr->value()->representation().IsDouble());
1959 ASSERT(instr->elements()->representation().IsTagged()); 1959 ASSERT(instr->elements()->representation().IsTagged());
1960 ASSERT(instr->key()->representation().IsInteger32()); 1960 ASSERT(instr->key()->representation().IsInteger32());
1961 1961
1962 LOperand* elements = UseRegisterAtStart(instr->elements()); 1962 LOperand* elements = UseRegisterAtStart(instr->elements());
1963 LOperand* val = UseTempRegister(instr->value()); 1963 LOperand* val = UseTempRegister(instr->value());
1964 LOperand* key = UseRegisterOrConstantAtStart(instr->key()); 1964 LOperand* key = UseRegisterOrConstantAtStart(instr->key());
1965 1965
1966 return new(zone()) LStoreKeyedFastDoubleElement(elements, key, val); 1966 return new(zone())
Jakob Kummerow 2012/05/15 15:53:23 nit: why this change?
1967 LStoreKeyedFastDoubleElement(elements, key, val);
1967 } 1968 }
1968 1969
1969 1970
1970 LInstruction* LChunkBuilder::DoStoreKeyedSpecializedArrayElement( 1971 LInstruction* LChunkBuilder::DoStoreKeyedSpecializedArrayElement(
1971 HStoreKeyedSpecializedArrayElement* instr) { 1972 HStoreKeyedSpecializedArrayElement* instr) {
1972 ElementsKind elements_kind = instr->elements_kind(); 1973 ElementsKind elements_kind = instr->elements_kind();
1973 ASSERT( 1974 ASSERT(
1974 (instr->value()->representation().IsInteger32() && 1975 (instr->value()->representation().IsInteger32() &&
1975 (elements_kind != EXTERNAL_FLOAT_ELEMENTS) && 1976 (elements_kind != EXTERNAL_FLOAT_ELEMENTS) &&
1976 (elements_kind != EXTERNAL_DOUBLE_ELEMENTS)) || 1977 (elements_kind != EXTERNAL_DOUBLE_ELEMENTS)) ||
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
2315 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2316 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2316 LOperand* object = UseRegister(instr->object()); 2317 LOperand* object = UseRegister(instr->object());
2317 LOperand* index = UseTempRegister(instr->index()); 2318 LOperand* index = UseTempRegister(instr->index());
2318 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2319 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2319 } 2320 }
2320 2321
2321 2322
2322 } } // namespace v8::internal 2323 } } // namespace v8::internal
2323 2324
2324 #endif // V8_TARGET_ARCH_X64 2325 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/x64/lithium-codegen-x64.cc ('K') | « src/x64/lithium-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698