Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Side by Side Diff: src/x64/lithium-x64.h

Issue 10382055: Array index computation dehoisting. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 LLoadKeyedFastElement(LOperand* elements, LOperand* key) { 1192 LLoadKeyedFastElement(LOperand* elements, LOperand* key) {
1193 inputs_[0] = elements; 1193 inputs_[0] = elements;
1194 inputs_[1] = key; 1194 inputs_[1] = key;
1195 } 1195 }
1196 1196
1197 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedFastElement, "load-keyed-fast-element") 1197 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedFastElement, "load-keyed-fast-element")
1198 DECLARE_HYDROGEN_ACCESSOR(LoadKeyedFastElement) 1198 DECLARE_HYDROGEN_ACCESSOR(LoadKeyedFastElement)
1199 1199
1200 LOperand* elements() { return inputs_[0]; } 1200 LOperand* elements() { return inputs_[0]; }
1201 LOperand* key() { return inputs_[1]; } 1201 LOperand* key() { return inputs_[1]; }
1202 uint32_t additional_index() const { return hydrogen()->index_offset(); }
1202 }; 1203 };
1203 1204
1204 1205
1205 class LLoadKeyedFastDoubleElement: public LTemplateInstruction<1, 2, 0> { 1206 class LLoadKeyedFastDoubleElement: public LTemplateInstruction<1, 2, 0> {
1206 public: 1207 public:
1207 LLoadKeyedFastDoubleElement(LOperand* elements, LOperand* key) { 1208 LLoadKeyedFastDoubleElement(LOperand* elements, LOperand* key) {
1208 inputs_[0] = elements; 1209 inputs_[0] = elements;
1209 inputs_[1] = key; 1210 inputs_[1] = key;
1210 } 1211 }
1211 1212
1212 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedFastDoubleElement, 1213 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedFastDoubleElement,
1213 "load-keyed-fast-double-element") 1214 "load-keyed-fast-double-element")
1214 DECLARE_HYDROGEN_ACCESSOR(LoadKeyedFastDoubleElement) 1215 DECLARE_HYDROGEN_ACCESSOR(LoadKeyedFastDoubleElement)
1215 1216
1216 LOperand* elements() { return inputs_[0]; } 1217 LOperand* elements() { return inputs_[0]; }
1217 LOperand* key() { return inputs_[1]; } 1218 LOperand* key() { return inputs_[1]; }
1219 uint32_t additional_index() const { return hydrogen()->index_offset(); }
1218 }; 1220 };
1219 1221
1220 1222
1221 class LLoadKeyedSpecializedArrayElement: public LTemplateInstruction<1, 2, 0> { 1223 class LLoadKeyedSpecializedArrayElement: public LTemplateInstruction<1, 2, 0> {
1222 public: 1224 public:
1223 LLoadKeyedSpecializedArrayElement(LOperand* external_pointer, 1225 LLoadKeyedSpecializedArrayElement(LOperand* external_pointer, LOperand* key) {
1224 LOperand* key) {
1225 inputs_[0] = external_pointer; 1226 inputs_[0] = external_pointer;
1226 inputs_[1] = key; 1227 inputs_[1] = key;
1227 } 1228 }
1228 1229
1229 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedSpecializedArrayElement, 1230 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedSpecializedArrayElement,
1230 "load-keyed-specialized-array-element") 1231 "load-keyed-specialized-array-element")
1231 DECLARE_HYDROGEN_ACCESSOR(LoadKeyedSpecializedArrayElement) 1232 DECLARE_HYDROGEN_ACCESSOR(LoadKeyedSpecializedArrayElement)
1232 1233
1233 LOperand* external_pointer() { return inputs_[0]; } 1234 LOperand* external_pointer() { return inputs_[0]; }
1234 LOperand* key() { return inputs_[1]; } 1235 LOperand* key() { return inputs_[1]; }
1235 ElementsKind elements_kind() const { 1236 ElementsKind elements_kind() const {
1236 return hydrogen()->elements_kind(); 1237 return hydrogen()->elements_kind();
1237 } 1238 }
1239 uint32_t additional_index() const { return hydrogen()->index_offset(); }
1238 }; 1240 };
1239 1241
1240 1242
1241 class LLoadKeyedGeneric: public LTemplateInstruction<1, 2, 0> { 1243 class LLoadKeyedGeneric: public LTemplateInstruction<1, 2, 0> {
1242 public: 1244 public:
1243 LLoadKeyedGeneric(LOperand* obj, LOperand* key) { 1245 LLoadKeyedGeneric(LOperand* obj, LOperand* key) {
1244 inputs_[0] = obj; 1246 inputs_[0] = obj;
1245 inputs_[1] = key; 1247 inputs_[1] = key;
1246 } 1248 }
1247 1249
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
1685 1687
1686 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedFastElement, 1688 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedFastElement,
1687 "store-keyed-fast-element") 1689 "store-keyed-fast-element")
1688 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedFastElement) 1690 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedFastElement)
1689 1691
1690 virtual void PrintDataTo(StringStream* stream); 1692 virtual void PrintDataTo(StringStream* stream);
1691 1693
1692 LOperand* object() { return inputs_[0]; } 1694 LOperand* object() { return inputs_[0]; }
1693 LOperand* key() { return inputs_[1]; } 1695 LOperand* key() { return inputs_[1]; }
1694 LOperand* value() { return inputs_[2]; } 1696 LOperand* value() { return inputs_[2]; }
1697 uint32_t additional_index() const { return hydrogen()->index_offset(); }
1695 }; 1698 };
1696 1699
1697 1700
1698 class LStoreKeyedFastDoubleElement: public LTemplateInstruction<0, 3, 0> { 1701 class LStoreKeyedFastDoubleElement: public LTemplateInstruction<0, 3, 0> {
1699 public: 1702 public:
1700 LStoreKeyedFastDoubleElement(LOperand* elements, 1703 LStoreKeyedFastDoubleElement(LOperand* elements,
1701 LOperand* key, 1704 LOperand* key,
1702 LOperand* val) { 1705 LOperand* val) {
1703 inputs_[0] = elements; 1706 inputs_[0] = elements;
1704 inputs_[1] = key; 1707 inputs_[1] = key;
1705 inputs_[2] = val; 1708 inputs_[2] = val;
1706 } 1709 }
1707 1710
1708 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedFastDoubleElement, 1711 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedFastDoubleElement,
1709 "store-keyed-fast-double-element") 1712 "store-keyed-fast-double-element")
1710 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedFastDoubleElement) 1713 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedFastDoubleElement)
1711 1714
1712 virtual void PrintDataTo(StringStream* stream); 1715 virtual void PrintDataTo(StringStream* stream);
1713 1716
1714 LOperand* elements() { return inputs_[0]; } 1717 LOperand* elements() { return inputs_[0]; }
1715 LOperand* key() { return inputs_[1]; } 1718 LOperand* key() { return inputs_[1]; }
1716 LOperand* value() { return inputs_[2]; } 1719 LOperand* value() { return inputs_[2]; }
1717 1720
1718 bool NeedsCanonicalization() { return hydrogen()->NeedsCanonicalization(); } 1721 bool NeedsCanonicalization() { return hydrogen()->NeedsCanonicalization(); }
1722 uint32_t additional_index() const { return hydrogen()->index_offset(); }
1719 }; 1723 };
1720 1724
1721 1725
1722 class LStoreKeyedSpecializedArrayElement: public LTemplateInstruction<0, 3, 0> { 1726 class LStoreKeyedSpecializedArrayElement: public LTemplateInstruction<0, 3, 0> {
1723 public: 1727 public:
1724 LStoreKeyedSpecializedArrayElement(LOperand* external_pointer, 1728 LStoreKeyedSpecializedArrayElement(LOperand* external_pointer,
1725 LOperand* key, 1729 LOperand* key,
1726 LOperand* val) { 1730 LOperand* val) {
1727 inputs_[0] = external_pointer; 1731 inputs_[0] = external_pointer;
1728 inputs_[1] = key; 1732 inputs_[1] = key;
1729 inputs_[2] = val; 1733 inputs_[2] = val;
1730 } 1734 }
1731 1735
1732 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedSpecializedArrayElement, 1736 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedSpecializedArrayElement,
1733 "store-keyed-specialized-array-element") 1737 "store-keyed-specialized-array-element")
1734 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedSpecializedArrayElement) 1738 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedSpecializedArrayElement)
1735 1739
1736 LOperand* external_pointer() { return inputs_[0]; } 1740 LOperand* external_pointer() { return inputs_[0]; }
1737 LOperand* key() { return inputs_[1]; } 1741 LOperand* key() { return inputs_[1]; }
1738 LOperand* value() { return inputs_[2]; } 1742 LOperand* value() { return inputs_[2]; }
1739 ElementsKind elements_kind() const { 1743 ElementsKind elements_kind() const {
1740 return hydrogen()->elements_kind(); 1744 return hydrogen()->elements_kind();
1741 } 1745 }
1746 uint32_t additional_index() const { return hydrogen()->index_offset(); }
1742 }; 1747 };
1743 1748
1744 1749
1745 class LStoreKeyedGeneric: public LTemplateInstruction<0, 3, 0> { 1750 class LStoreKeyedGeneric: public LTemplateInstruction<0, 3, 0> {
1746 public: 1751 public:
1747 LStoreKeyedGeneric(LOperand* object, LOperand* key, LOperand* value) { 1752 LStoreKeyedGeneric(LOperand* object, LOperand* key, LOperand* value) {
1748 inputs_[0] = object; 1753 inputs_[0] = object;
1749 inputs_[1] = key; 1754 inputs_[1] = key;
1750 inputs_[2] = value; 1755 inputs_[2] = value;
1751 } 1756 }
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
2373 2378
2374 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2379 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2375 }; 2380 };
2376 2381
2377 #undef DECLARE_HYDROGEN_ACCESSOR 2382 #undef DECLARE_HYDROGEN_ACCESSOR
2378 #undef DECLARE_CONCRETE_INSTRUCTION 2383 #undef DECLARE_CONCRETE_INSTRUCTION
2379 2384
2380 } } // namespace v8::int 2385 } } // namespace v8::int
2381 2386
2382 #endif // V8_X64_LITHIUM_X64_H_ 2387 #endif // V8_X64_LITHIUM_X64_H_
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698