Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 10382051: Add initial GTK web accessibility framework (third attempt). (Closed)

Created:
8 years, 7 months ago by dmazzoni
Modified:
8 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, ctguil+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, penghuang+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, James Su, zork+watch_chromium.org
Visibility:
Public.

Description

Add initial GTK web accessibility framework (third attempt). Previous attempts to land this patch: 1. http://codereview.chromium.org/9839069/ 2. http://codereview.chromium.org/10382013/ The previous attempts failed to land due to test failures and problems depending on libatk with the official Linux build. The build is now resolved, and the test failures have been fixed by adding an IsNative method to BrowserAccessibility. Please look carefully at the IsNative calls in the code; the rest is the same. Original description: This enables Linux desktop assistive technology such as the Orca screen reader to access the web contents. Builds on the same accessibility stack used by Mac & Windows already. This change works with Orca now, but it's minimal: all that works is getting the correct feedback when you tab through focusable links and controls in a webpage. Future changes will add the rest of the support. BUG=24585 TEST=Run Chrome on desktop Linux with Orca turned on, tab through links. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135998

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 5

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+788 lines, -76 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 2 3 4 5 3 chunks +10 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 5 2 chunks +9 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 5 chunks +5 lines, -5 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_gtk.h View 1 2 3 4 5 6 1 chunk +93 lines, -0 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_gtk.cc View 1 2 3 4 5 6 1 chunk +347 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.h View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.mm View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_mac_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_manager_gtk.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_manager_gtk.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 5 27 chunks +32 lines, -28 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
MM content/browser/accessibility/dump_accessibility_tree_helper_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 5 chunks +24 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 6 chunks +76 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/gtk_preserve_window.h View 1 3 chunks +10 lines, -1 line 0 comments Download
M ui/gfx/gtk_preserve_window.cc View 1 4 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmazzoni
To see what changed from the previous version, look for IsNative.
8 years, 7 months ago (2012-05-08 16:24:59 UTC) #1
David Tseng
http://codereview.chromium.org/10382051/diff/11008/content/browser/accessibility/browser_accessibility.cc File content/browser/accessibility/browser_accessibility.cc (right): http://codereview.chromium.org/10382051/diff/11008/content/browser/accessibility/browser_accessibility.cc#newcode84 content/browser/accessibility/browser_accessibility.cc:84: bool BrowserAccessibility::IsNative() { const? http://codereview.chromium.org/10382051/diff/11008/content/browser/accessibility/browser_accessibility_gtk.h File content/browser/accessibility/browser_accessibility_gtk.h (right): http://codereview.chromium.org/10382051/diff/11008/content/browser/accessibility/browser_accessibility_gtk.h#newcode5 ...
8 years, 7 months ago (2012-05-08 16:52:59 UTC) #2
dmazzoni
The only lint error I found was changing a 2011 to 2012, did you see ...
8 years, 7 months ago (2012-05-08 17:33:32 UTC) #3
David Tseng
8 years, 7 months ago (2012-05-08 17:47:54 UTC) #4
lgtm.

On 5/8/12, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
> The only lint error I found was changing a 2011 to 2012, did you see
> anything
> else?
> The header include order in the *gtk* files. (C system header should go
earlier).

Powered by Google App Engine
This is Rietveld 408576698