Added support for Google Drive's external app document type

Added support for handling external app documents. These should much behave pretty much the same as Google Documents with exception that they are hosted on external sites. This CL will expose them as files with .glink extension just like like drive clients do.

BUG=126895
TEST=GDataParserTest.DocumentFeedJsonParser

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137729

[Vladislav Kaznacheev, 2012-05-16 08:02:33]

File Manager UI LGTM

[satorux1, 2012-05-16 20:07:09]

LGTM

http://codereview.chromium.org/10381155/diff/1005/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_parser.h (right):

http://codereview.chromium.org/10381155/diff/1005/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_parser.h:379: bool is_external_app() const {
return (kind_ & 0x002200) == 0x002200; }
maybe is_external_app_document() to be more descriptive?

http://codereview.chromium.org/10381155/diff/1005/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_parser_unittest.cc (right):

http://codereview.chromium.org/10381155/diff/1005/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:173:
EXPECT_TRUE(document_entry->is_google_document());
might want to add

EXPECT_FALSE(app_entry->is_external_app());

http://codereview.chromium.org/10381155/diff/1005/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:180:
EXPECT_TRUE(app_entry->is_external_app());
might want to add

EXPECT_FALSE(document_entry->is_google_document());

[zel, 2012-05-16 20:56:14]

https://chromiumcodereview.appspot.com/10381155/diff/1005/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_parser.h (right):

https://chromiumcodereview.appspot.com/10381155/diff/1005/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_parser.h:379: bool is_external_app() const {
return (kind_ & 0x002200) == 0x002200; }
On 2012/05/16 20:07:09, satorux1 wrote:
> maybe is_external_app_document() to be more descriptive?

Done.

https://chromiumcodereview.appspot.com/10381155/diff/1005/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_parser_unittest.cc (right):

https://chromiumcodereview.appspot.com/10381155/diff/1005/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:173:
EXPECT_TRUE(document_entry->is_google_document());
On 2012/05/16 20:07:09, satorux1 wrote:
> might want to add
> 
> EXPECT_FALSE(app_entry->is_external_app());

Done.

https://chromiumcodereview.appspot.com/10381155/diff/1005/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:180:
EXPECT_TRUE(app_entry->is_external_app());
On 2012/05/16 20:07:09, satorux1 wrote:
> might want to add
> 
> EXPECT_FALSE(document_entry->is_google_document());

Done.

[commit-bot: I haz the power, 2012-05-16 20:56:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10381155/1007

[commit-bot: I haz the power, 2012-05-16 20:57:09]

Presubmit check for 10381155-1007 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources

Presubmit checks took 1.9s to calculate.

[csilv, 2012-05-16 20:59:41]

chrome/browser/resources lgtm

[commit-bot: I haz the power, 2012-05-16 21:03:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10381155/1007

[commit-bot: I haz the power, 2012-05-16 21:32:10]

Try job failure for 10381155-1007 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...