Fix directory listing to actually have the semantics intended.

runtime/bin/directory_posix.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <sys/param.h>
 #include <sys/stat.h>
@@ skipping 116 matching lines @@
 
   // Iterated the directory and post the directories and files to the
   // ports.
   int read = 0;
   bool success = true;
   dirent entry;
   dirent* result;
   while ((read = TEMP_FAILURE_RETRY(readdir_r(dir_pointer,
                                               &entry,
                                               &result))) == 0 &&
-         result != NULL &&
-         success) {
+         result != NULL) {
     switch (entry.d_type) {
       case DT_DIR:
-        success = success && HandleDir(entry.d_name,
-                                       path,
-                                       path_length,
-                                       recursive,
-                                       listing);
+        success = HandleDir(entry.d_name,
+                            path,
+                            path_length,
+                            recursive,
+                            listing) && success;
         break;
       case DT_REG:
-        success = success && HandleFile(entry.d_name,
-                                        path,
-                                        path_length,
-                                        listing);
+        success = HandleFile(entry.d_name,
+                             path,
+                             path_length,
+                             listing) && success;
         break;
       case DT_LNK:
       case DT_UNKNOWN: {
         // On some file systems the entry type is not determined by
         // readdir_r. For those and for links we use stat to determine
         // the actual entry type. Notice that stat returns the type of
         // the file pointed to.
         struct stat entry_info;
         size_t written = snprintf(path + path_length,
                                   PATH_MAX - path_length,
                                   "%s",
                                   entry.d_name);
         if (written != strlen(entry.d_name)) {
           success = false;
           break;
         }
         int stat_success = TEMP_FAILURE_RETRY(stat(path, &entry_info));
         if (stat_success == -1) {
           success = false;
           PostError(listing, path);
           break;
         }
         if (S_ISDIR(entry_info.st_mode)) {
-          success = success && HandleDir(entry.d_name,
-                                         path,
-                                         path_length,
-                                         recursive,
-                                         listing);
+          success = HandleDir(entry.d_name,
+                              path,
+                              path_length,
+                              recursive,
+                              listing) && success;
         } else if (S_ISREG(entry_info.st_mode)) {
-          success = success && HandleFile(entry.d_name,
-                                          path,
-                                          path_length,
-                                          listing);
+          success = HandleFile(entry.d_name,
+                               path,
+                               path_length,
+                               listing) && success;
         }
         ASSERT(!S_ISLNK(entry_info.st_mode));
         break;
       }
       default:
         break;
     }
   }
 
   if (read != 0) {
@@ skipping 222 matching lines @@
 }
 
 
 bool Directory::Delete(const char* dir_name, bool recursive) {
   if (!recursive) {
     return (TEMP_FAILURE_RETRY(remove(dir_name)) == 0);
   } else {
     return DeleteRecursively(dir_name);
   }
 }