Issue 10381148: Style fix in Android DeviceOrientation header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10381148: Style fix in Android DeviceOrientation header. (Closed)

Created:
8 years, 7 months ago by John Knottenbelt

Modified:
8 years, 7 months ago

Reviewers:
hans, bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, bulach

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Style fix in Android DeviceOrientation header. rateInMilliseconds should be rate_in_milliseconds. BUG=Style TEST=Existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137122

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/device_orientation/data_fetcher_impl_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

hans

On 2012/05/15 09:21:07, John Knottenbelt wrote: LGTM, ship it :)

8 years, 7 months ago (2012-05-15 09:39:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10381148/1

8 years, 7 months ago (2012-05-15 10:02:37 UTC) #4

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

8 years, 7 months ago (2012-05-15 11:11:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10381148/1

8 years, 7 months ago (2012-05-15 12:48:56 UTC) #6

Change committed as 137122