Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10381140: Add a method to WebContentsTester to set the loading state of the (Closed)

Created:
8 years, 7 months ago by Munjal (Google)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a method to WebContentsTester to set the loading state of the underlying WebContents. This will aid in testing more scenarios with WebContents. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/web_contents/test_web_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/test_web_contents.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/web_contents_tester.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Munjal (Google)
8 years, 7 months ago (2012-05-15 00:26:27 UTC) #1
Jói
LGTM Ben, FYI, Munjal had discussed this with me beforehand, it is to help him ...
8 years, 7 months ago (2012-05-15 00:47:24 UTC) #2
Ben Goodger (Google)
k On Mon, May 14, 2012 at 5:47 PM, <joi@chromium.org> wrote: > LGTM > > ...
8 years, 7 months ago (2012-05-15 16:05:54 UTC) #3
Munjal (Google)
Ben, can you LGTM. Joi is not in OWNERS.
8 years, 7 months ago (2012-05-15 17:21:30 UTC) #4
jam
lgtm
8 years, 7 months ago (2012-05-15 19:00:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10381140/1
8 years, 7 months ago (2012-05-15 19:03:04 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 21:12:54 UTC) #7
Change committed as 137241

Powered by Google App Engine
This is Rietveld 408576698