Add SearchProvider's most relevant NavigationResult to |matches_|.

Add SearchProvider's most relevant NavigationResult to |matches_|.

This fixes a regression from http://crrev.com/135984.
The reversed result parsing unintentionally left the nav results unsorted.
Suggest results are unaffected, as they're all added to map and sorted.

Subsequent CLs should help make this whole process cleaner.

BUG=125871
TEST=Automated. Also, the *first* NAVIGATION result from suggest JSON is used as a SearchProvider match.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137080

[msw, 2012-05-12 01:44:47]

Update SearchProviderTest.Navsuggest with test case.

[msw, 2012-05-12 01:49:47]

Hey Peter, please take a look as you have time; thanks!

[Peter Kasting, 2012-05-14 20:29:19]

LGTM with one change

https://chromiumcodereview.appspot.com/10381121/diff/2001/chrome/browser/auto...
File chrome/browser/autocomplete/search_provider.cc (right):

https://chromiumcodereview.appspot.com/10381121/diff/2001/chrome/browser/auto...
chrome/browser/autocomplete/search_provider.cc:662:
std::stable_sort(navigation_results.begin(), navigation_results.end(),
Use std::max_element() instead of sorting and then pulling off the front.  This
also avoids the need to pass by copy.

[msw, 2012-05-15 01:00:29]

Done; I'll land with green try jobs, but feel free to take another look.

https://chromiumcodereview.appspot.com/10381121/diff/2001/chrome/browser/auto...
File chrome/browser/autocomplete/search_provider.cc (right):

https://chromiumcodereview.appspot.com/10381121/diff/2001/chrome/browser/auto...
chrome/browser/autocomplete/search_provider.cc:662:
std::stable_sort(navigation_results.begin(), navigation_results.end(),
On 2012/05/14 20:29:19, Peter Kasting wrote:
> Use std::max_element() instead of sorting and then pulling off the front. 
This
> also avoids the need to pass by copy.

Done.

[commit-bot: I haz the power, 2012-05-15 03:03:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10381121/9001

[commit-bot: I haz the power, 2012-05-15 05:21:15]

Change committed as 137080