Add .clean_trace() to the APIs to delete the stale traces.

Add .clean_trace() to the APIs to delete the stale traces.

It'll become soon more complex for strace so it's preferable to have a proper
interface.

R=mad@chromium.org
BUG=98636
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136655

[MAD, 2012-05-11 18:51:38]

One question and an associated suggestion...

https://chromiumcodereview.appspot.com/10381112/diff/1/tools/isolate/trace_in...
File tools/isolate/trace_inputs.py (right):

https://chromiumcodereview.appspot.com/10381112/diff/1/tools/isolate/trace_in...
tools/isolate/trace_inputs.py:396: os.remove(logname)
Shouldn't we try to catch these?

"On Windows, attempting to remove a file that is in use causes an exception to
be raised"

And if so, instead of repeating this code in all classes, why not have a method
to retrieve all log file names in an array and iterate over it with a single
exception proof remove file implementation... No?

[M-A Ruel, 2012-05-11 18:57:24]

https://chromiumcodereview.appspot.com/10381112/diff/1/tools/isolate/trace_in...
File tools/isolate/trace_inputs.py (right):

https://chromiumcodereview.appspot.com/10381112/diff/1/tools/isolate/trace_in...
tools/isolate/trace_inputs.py:396: os.remove(logname)
On 2012/05/11 18:51:38, MAD wrote:
> Shouldn't we try to catch these?

I prefer the script to crash if the files can't be removed. Since it'll fail
later anyway.

BTW, you meant line 1029. line 396 is never executed on windows.

> And if so, instead of repeating this code in all classes, why not have a
method
> to retrieve all log file names in an array and iterate over it with a single
> exception proof remove file implementation... No?

Exceptions are only an issue on Windows. And I want them to be fatal anyway. I
also prefer the caller to not have to do anything with the function result.

[MAD, 2012-05-11 18:59:34]

OK then, LGTM!

Thanks for the answer...

BYE
MAD!

[commit-bot: I haz the power, 2012-05-11 19:00:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10381112/1

[commit-bot: I haz the power, 2012-05-11 20:44:37]

Change committed as 136655