Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4447)

Unified Diff: chrome/browser/extensions/page_box_controller.h

Issue 10381105: Refactor UI "badge" (page action) logic into a BadgeController interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_box_controller.h
diff --git a/chrome/browser/extensions/page_box_controller.h b/chrome/browser/extensions/page_box_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..e3e5441fdbde0563b6dd33a001c22fdfac5164af
--- /dev/null
+++ b/chrome/browser/extensions/page_box_controller.h
@@ -0,0 +1,65 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_PAGE_BOX_CONTROLLER_H_
+#define CHROME_BROWSER_EXTENSIONS_PAGE_BOX_CONTROLLER_H_
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "base/memory/scoped_ptr.h"
+
+class ExtensionAction;
+
+namespace extensions {
+
+// Controller of the "badges" (aka "page actions") in the UI.
+class PageBoxController {
+ public:
+ // UI decoration on a page box item.
+ enum Decoration {
+ DECORATION_NONE,
+ };
+
+ // Data about a UI badge.
+ struct Data {
+ // The type of decoration that should be applied to the badge.
+ Decoration decoration;
+
+ // The ExtensionAction that corresponds to the badge.
+ ExtensionAction* action;
+ };
+
+ // Mouse button type passed into OnClicked.
+ enum MouseButton {
+ MOUSE_LEFT,
Evan Stade 2012/05/14 19:24:07 if you make this = 1, and the next = 2, etc., then
+ MOUSE_MIDDLE,
+ MOUSE_RIGHT,
+ };
+
+ typedef std::vector<Data> DataList;
+
+ // The reaction that the UI should take after executing |OnClicked|.
+ enum Action {
+ ACTION_NONE,
+ ACTION_SHOW_POPUP,
+ ACTION_SHOW_CONTEXT_MENU,
+ };
+
+ virtual ~PageBoxController() {}
+
+ // Gets the badge data for all extensions.
+ virtual scoped_ptr<DataList> GetAllBadgeData() = 0;
+
+ // Notifies this that the badge for an extension has been clicked with some
+ // mouse button (1 for left, 2 for middle, and 3 for right click), and
+ // returns the action that should be taken in response (if any).
+ virtual Action OnClicked(const std::string& extension_id,
+ MouseButton button) = 0;
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_PAGE_BOX_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698