Move content settings extension API to content_settings dir.

Move content settings extension API to content_settings dir.

We're moving all the extension api implementations out of
browser/extensions into the directory with the code they are
automating.

BUG=101244
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137574

[chebert, 2012-05-10 22:57:41]

Just a refactor. No change in functionality.

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/browser/content...
File chrome/browser/content_settings/extension_content_settings_api_constants.cc
(right):

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/browser/content...
chrome/browser/content_settings/extension_content_settings_api_constants.cc:31: 
Remove newline

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/browser/content...
File chrome/browser/content_settings/extension_content_settings_unittest.cc
(right):

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/browser/content...
chrome/browser/content_settings/extension_content_settings_unittest.cc:52: 
remove newline.

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_function_registry.cc (right):

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_function_registry.cc:26: #include
"chrome/browser/content_settings/extension_content_settings_api.h"
Move to top.

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://chromiumcodereview.appspot.com/10381097/diff/1/chrome/chrome_tests.gy...
chrome/chrome_tests.gypi:2689:
'browser/content_settings/extension_content_settings_apitest.cc',
Run api_tests

[Matt Perry, 2012-05-11 20:44:11]

lgtm

[Aaron Boodman, 2012-05-11 21:18:26]

https://chromiumcodereview.appspot.com/10381097/diff/2002/chrome/browser/exte...
File chrome/browser/extensions/api/content_settings/content_settings_api.h
(right):

https://chromiumcodereview.appspot.com/10381097/diff/2002/chrome/browser/exte...
chrome/browser/extensions/api/content_settings/content_settings_api.h:17: class
ClearContentSettingsFunction : public SyncExtensionFunction {
If you do more of these, can you put them in the 'extensions' namespace at the
same time?

Not a big deal, but that's another little cleanup that would be nice.

[chebert, 2012-05-12 01:22:07]

Like so?

I changed everything in the c/b/e/api/content_settings/ folder to be in the
extensions namespace.
I also changed ExtensionContentSettingsStore to ContentSettingsStore.

On 2012/05/11 21:18:26, Aaron Boodman wrote:
>
https://chromiumcodereview.appspot.com/10381097/diff/2002/chrome/browser/exte...
> File chrome/browser/extensions/api/content_settings/content_settings_api.h
> (right):
> 
>
https://chromiumcodereview.appspot.com/10381097/diff/2002/chrome/browser/exte...
> chrome/browser/extensions/api/content_settings/content_settings_api.h:17:
class
> ClearContentSettingsFunction : public SyncExtensionFunction {
> If you do more of these, can you put them in the 'extensions' namespace at the
> same time?
> 
> Not a big deal, but that's another little cleanup that would be nice.

[chebert, 2012-05-12 01:24:41]

https://chromiumcodereview.appspot.com/10381097/diff/2002/chrome/browser/exte...
File chrome/browser/extensions/api/content_settings/content_settings_api.h
(right):

https://chromiumcodereview.appspot.com/10381097/diff/2002/chrome/browser/exte...
chrome/browser/extensions/api/content_settings/content_settings_api.h:17: class
ClearContentSettingsFunction : public SyncExtensionFunction {
On 2012/05/11 21:18:26, Aaron Boodman wrote:
> If you do more of these, can you put them in the 'extensions' namespace at the
> same time?
> 
> Not a big deal, but that's another little cleanup that would be nice.

Done.

https://chromiumcodereview.appspot.com/10381097/diff/3003/chrome/browser/exte...
File
chrome/browser/extensions/api/content_settings/content_settings_api_constants.h
(right):

https://chromiumcodereview.appspot.com/10381097/diff/3003/chrome/browser/exte...
chrome/browser/extensions/api/content_settings/content_settings_api_constants.h:32:
}
Add "namespace content_settings_api_constants"

[commit-bot: I haz the power, 2012-05-12 17:44:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10381...

[commit-bot: I haz the power, 2012-05-12 19:06:34]

Can't apply patch for file
chrome/browser/extensions/extension_function_registry.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/extension_function_registry.cc
Hunk #1 FAILED at 10.
Hunk #2 FAILED at 24.
2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_registry.cc.rej

[Aaron Boodman, 2012-05-14 23:15:22]

On 2012/05/12 01:22:07, chebert wrote:
> Like so?
> 
> I changed everything in the c/b/e/api/content_settings/ folder to be in the
> extensions namespace.
> I also changed ExtensionContentSettingsStore to ContentSettingsStore.

Cool, thanks.

[commit-bot: I haz the power, 2012-05-16 00:05:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10381...

[commit-bot: I haz the power, 2012-05-16 03:46:13]

Can't apply patch for file
chrome/browser/extensions/extension_function_registry.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/extension_function_registry.cc
Hunk #1 FAILED at 10.
Hunk #2 FAILED at 25.
2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_registry.cc.rej

[commit-bot: I haz the power, 2012-05-16 22:29:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10381...

[commit-bot: I haz the power, 2012-05-17 00:11:40]

Change committed as 137574