Issue 10381089: Revert 136296 - Make all extension api types fully qualified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10381089: Revert 136296 - Make all extension api types fully qualified. (Closed)

Created:
8 years, 7 months ago by yzshen1

Modified:
8 years, 7 months ago

Reviewers:
bryeung

CC:
chromium-reviews, brettw-cc_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 136296 - Make all extension api types fully qualified. BUG=123073 TEST= (unit_tests --gtest_filter=ExtensionAPI) && (browser_tests --gtest_filter=ExtensionApiTest) Review URL: https://chromiumcodereview.appspot.com/10367002 TBR=bryeung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136323

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -427 lines)			Patch
M	chrome/common/extensions/api/browserAction.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/contextMenus.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/declarativeWebRequest.json	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/api/devtools_api.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/experimental.bookmarkManager.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/experimental.infobars.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/extension.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	2 chunks	+2 lines, -66 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api_unittest.cc	View	1 chunk	+0 lines, -69 lines	0 comments	Download
M	chrome/common/extensions/api/pageAction.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/privacy.json	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/common/extensions/api/proxy.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/tabs.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/ttsEngine.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/windows.json	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/docs/browserAction.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/contextMenus.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/declarativeWebRequest.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/devtools.panels.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.alarms.html	View	13 chunks	+16 lines, -16 lines	0 comments	Download
MM	chrome/common/extensions/docs/experimental.infobars.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/extension.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/pageAction.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/privacy.html	View	11 chunks	+11 lines, -11 lines	0 comments	Download
MM	chrome/common/extensions/docs/proxy.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/tabs.html	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/ttsEngine.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/windows.html	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/renderer/resources/extensions/content_settings_custom_bindings.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/resources/extensions/storage_custom_bindings.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/resources/extensions/types_custom_bindings.js	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/test/data/extensions/extension_api_unittest/types_have_namespace.json	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	tools/json_schema_compiler/cc_generator.py	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_type_generator.py	View	6 chunks	+28 lines, -16 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_type_generator_test.py	View	4 chunks	+12 lines, -11 lines	0 comments	Download
M	tools/json_schema_compiler/h_generator.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/json_schema_compiler/idl_schema.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/json_schema_compiler/idl_schema_test.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/json_schema_compiler/json_schema.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tools/json_schema_compiler/model_test.py	View	1 chunk	+8 lines, -9 lines	0 comments	Download
D	tools/json_schema_compiler/schema_util.py	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	tools/json_schema_compiler/schema_util_test.py	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	tools/json_schema_compiler/test/crossref.json	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/json_schema_compiler/test/dependencyTester.json	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/json_schema_compiler/test/windows.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

lgtm

Expand Messages | Collapse Messages