Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 10381066: Use generic package name retrieval. (Closed)

Created:
8 years, 7 months ago by nyquist
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Use generic package name retrieval. The manifest package name should not be hardcoded, but instead read from the context. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/android/java/org/chromium/base/BuildInfo.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yaron
lgtm Jay, can you rubberstamp?
8 years, 7 months ago (2012-05-09 00:11:07 UTC) #1
Jay Civelli
lgtm
8 years, 7 months ago (2012-05-09 00:18:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10381066/1
8 years, 7 months ago (2012-05-09 00:19:22 UTC) #3
commit-bot: I haz the power
Try job failure for 10381066-1 (retry) on win_rel for step "update" (clobber build). It's a ...
8 years, 7 months ago (2012-05-09 00:55:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10381066/1
8 years, 7 months ago (2012-05-09 01:03:44 UTC) #5
commit-bot: I haz the power
Try job failure for 10381066-1 (retry) on win_rel for step "update". It's a second try, ...
8 years, 7 months ago (2012-05-09 03:03:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10381066/1
8 years, 7 months ago (2012-05-09 06:06:00 UTC) #7
commit-bot: I haz the power
Try job failure for 10381066-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-09 08:36:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10381066/1
8 years, 7 months ago (2012-05-09 18:04:54 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 19:47:44 UTC) #10
Change committed as 136096

Powered by Google App Engine
This is Rietveld 408576698