Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 10381064: Remove the gyp flag for registerProtocolHandler. (Closed)

Created:
8 years, 7 months ago by tony
Modified:
8 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Remove the gyp flag for registerProtocolHandler. We've been shipping RPH for a while with no adverse effects so it should be safe to remove the flag. BUG=126569 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136129

Patch Set 1 #

Total comments: 1

Patch Set 2 : move include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -49 lines) Patch
M build/common.gypi View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 chunk +20 lines, -22 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler2.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/handler_options_handler2.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tony
This depends on https://bugs.webkit.org/show_bug.cgi?id=85924 , so I'll wait for that to land before running a ...
8 years, 7 months ago (2012-05-08 22:56:47 UTC) #1
koz (OOO until 15th September)
lgtm
8 years, 7 months ago (2012-05-08 23:00:12 UTC) #2
benwells
lgtm
8 years, 7 months ago (2012-05-08 23:37:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10381064/1
8 years, 7 months ago (2012-05-09 19:03:01 UTC) #4
commit-bot: I haz the power
Presubmit check for 10381064-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-09 19:03:11 UTC) #5
tony
+estade,jhawkins for OWNERS
8 years, 7 months ago (2012-05-09 19:12:48 UTC) #6
James Hawkins
LGTM with nit. https://chromiumcodereview.appspot.com/10381064/diff/1/chrome/browser/resources/options2/options.html File chrome/browser/resources/options2/options.html (right): https://chromiumcodereview.appspot.com/10381064/diff/1/chrome/browser/resources/options2/options.html#newcode130 chrome/browser/resources/options2/options.html:130: <include src="handler_options.html"> nit: Move this up ...
8 years, 7 months ago (2012-05-09 19:24:27 UTC) #7
tony
On 2012/05/09 19:24:27, James Hawkins wrote: > LGTM with nit. > > https://chromiumcodereview.appspot.com/10381064/diff/1/chrome/browser/resources/options2/options.html > File ...
8 years, 7 months ago (2012-05-09 19:38:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10381064/2003
8 years, 7 months ago (2012-05-09 19:39:01 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 21:34:27 UTC) #10
Change committed as 136129

Powered by Google App Engine
This is Rietveld 408576698