Show the "cannot proceed" text only when appropriate.

Show the "cannot proceed" text only when appropriate.

Fix some simple lints while here.

BUG=122498
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137349

[palmer, 2012-05-08 00:55:18]

abarth for content/browser/ssl OWNERS, and rdsmith for content/public/browser
OWNERS (although the comment is "# rdsmith@chromium.org for download related
code", there are no other owners listed in that file).

[Randy Smith (Not in Mondays), 2012-05-08 06:10:33]

I'm in that OWNERS file because it's the tightest limit manageable to the
approval I can give.  Anyone in content/public/OWNERS or content/OWNERS can
review changes in content/public/browser (and should if they aren't downloads
related).  Replacing myself with avi.

[Avi (use Gerrit), 2012-05-08 07:55:32]

I know nothing about SSL. If you can get someone to say OK about the SSL changes
(which are the content changes) I will rubberstamp them.

[palmer, 2012-05-08 17:27:27]

Thanks, rdsmith and avi. Adding rsleevi for HTTPS savoir-faire.

[Ryan Sleevi, 2012-05-08 17:53:49]

As mentioned over IM, this approach LGTM. |overridable| indicates application
policy, and |strict_enforcement| indicates site policy, so I agree we want to
track these separately.

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/chro...
File chrome/browser/chrome_content_browser_client.h (right):

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/chro...
chrome/browser/chrome_content_browser_client.h:12: #include <vector>
nit: sort

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/ssl/...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/ssl/...
chrome/browser/ssl/ssl_blocking_page.cc:114: strings.SetString("cannotProceed",
nit { }

[palmer, 2012-05-08 18:40:43]

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/chro...
File chrome/browser/chrome_content_browser_client.h (right):

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/chro...
chrome/browser/chrome_content_browser_client.h:12: #include <vector>
> nit: sort

It is sorted. :)

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/ssl/...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://chromiumcodereview.appspot.com/10381051/diff/5001/chrome/browser/ssl/...
chrome/browser/ssl/ssl_blocking_page.cc:114: strings.SetString("cannotProceed",
On 2012/05/08 17:53:49, Ryan Sleevi wrote:
> nit { }

Done.

[abarth-chromium, 2012-05-15 18:34:33]

LGTM.  (Hopefully that helps with some OWNERS files.)

[Avi (use Gerrit), 2012-05-15 19:18:47]

lgtm

[commit-bot: I haz the power, 2012-05-15 20:47:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/palmer@chromium.org/10381051/1012

[commit-bot: I haz the power, 2012-05-15 21:03:22]

Try job failure for 10381051-1012 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[palmer, 2012-05-15 21:10:30]

Oops, I had fixed the build failures locally but had forgotten to gcl upload.
And now I need more OWNERS, of course. :) Adding sky and ben because they own
ash and ui/views. The changes in those files are trivial.

[palmer, 2012-05-15 21:11:22]

Adding ben and sky as OWNERS. Thanks!

[Ben Goodger (Google), 2012-05-15 21:17:15]

LGTM for ui/views

[commit-bot: I haz the power, 2012-05-15 23:59:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/palmer@chromium.org/10381051/17001

[commit-bot: I haz the power, 2012-05-16 03:41:36]

Change committed as 137349