Improve type checking, remove unused stub (removed also in x64 in preparation of porting the better…

runtime/vm/flow_graph_compiler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 140 matching lines @@
       }
       // Compare if the classes are equal.
       __ Bind(&compare_classes);
       // If type is an interface, we can skip the class equality check,
       // because instances cannot be of an interface type.
       if (!type_class.is_interface()) {
         __ LoadObject(RCX, type_class);
         __ movq(R10, FieldAddress(RAX, Object::class_offset()));
         __ cmpq(R10, RCX);
         __ j(EQUAL, is_instance);
-        // RAX, RCX, and RDX are preserved in stub, result is in RBX.
-        __ call(&StubCode::IsRawSubTypeLabel());
-        // Result in RBX: 1 is raw subtype.
-        __ cmpq(RBX, Immediate(1));
-        __ j(EQUAL, is_instance);
-          // Otherwise fall through to runtime call.
+        // TODO(srdjan): Finish implementation.
+        // Otherwise fall through to runtime call.
       } else {
         // However, for specific core library interfaces, we can check for
         // specific core library classes.
         Error& malformed_error = Error::Handle();
         if (type.IsBoolInterface()) {
           __ movq(RCX, FieldAddress(RAX, Object::class_offset()));
           const Class& bool_class = Class::ZoneHandle(
               Isolate::Current()->object_store()->bool_class());
           __ CompareObject(RCX, bool_class);
           __ j(EQUAL, is_instance);
@@ skipping 32 matching lines @@
           __ CompareObject(RCX, four_byte_string_class);
           __ j(EQUAL, is_instance);
         } else if (type.IsFunctionInterface()) {
           const Immediate raw_null =
               Immediate(reinterpret_cast<intptr_t>(Object::null()));
           __ movq(RCX, FieldAddress(RAX, Object::class_offset()));
           __ movq(RCX, FieldAddress(RCX, Class::signature_function_offset()));
           __ cmpq(RCX, raw_null);
           __ j(NOT_EQUAL, is_instance);
         } else {
-          __ LoadObject(RCX, type_class);
-          // RAX: Instance (preserved).
-          // RCX: test class (preserved).
-          // RDX: instantiator type arguments (preserved).
-          __ call(&StubCode::IsRawSubTypeLabel());
-          // Result in RBX: 1 is raw subtype.
-          __ cmpq(RBX, Immediate(1));
-          __ j(EQUAL, is_instance);
-          // Otherwise fallthrough to runtime call.
+          // TODO(srdjan): Finish implementation.
         }
       }
     }
   } else {
     ASSERT(!type.IsInstantiated());
     // Skip check if destination is a dynamic type.
     if (type.IsTypeParameter()) {
       // Check if dynamic.
       const Immediate raw_null =
           Immediate(reinterpret_cast<intptr_t>(Object::null()));
@@ skipping 22 matching lines @@
       // The instantiated type parameter RCX may not be a Type, but could be an
       // InstantiatedType. It is therefore necessary to check its class.
       __ movq(R10, FieldAddress(RCX, Object::class_offset()));
       __ CompareObject(R10, Object::ZoneHandle(Object::type_class()));
       __ j(NOT_EQUAL, &runtime_call, Assembler::kNearJump);
       __ movq(RCX, FieldAddress(RCX, Type::type_class_offset()));
       __ movq(R10, FieldAddress(RCX, Class::type_parameters_offset()));
       // Check that class of type has no type parameters.
       __ cmpq(R10, raw_null);
       __ j(NOT_EQUAL, &runtime_call, Assembler::kNearJump);
-      // We have a non-parameterized class in RCX, compare with class of
-      // value in RAX. RAX, RCX, and RDX are preserved in stub.
-      __ call(&StubCode::IsRawSubTypeLabel());
-      // Result in EBX: 1 is raw subtype.
-      __ cmpq(RBX, Immediate(1));
-      __ j(EQUAL, is_instance);
+      // TODO(srdjan): Implement subtype test cache.
       // Fall through to runtime call.
     }
   }
   __ Bind(&runtime_call);
 }
 
 
 // Optimize assignable type check by adding inlined tests for:
 // - NULL -> return NULL.
 // - Smi -> compile time subtype check (only if dst class is not parameterized).
@@ skipping 1439 matching lines @@
   ASSERT(exception_handlers_list_ != NULL);
   const ExceptionHandlers& handlers = ExceptionHandlers::Handle(
       exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint()));
   code.set_exception_handlers(handlers);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64