Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10381043: Let android_gyp pass extra parameters to gyp (Closed)

Created:
8 years, 7 months ago by Xianzhu
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews
Visibility:
Public.

Description

Let android_gyp pass extra parameters to gyp This is useful for example android_gyp --help or android_gyp --format=dump_dependency_json (to generate a dependency graph). BUG=none TEST=Run android_gyp --help Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/envsetup.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Xianzhu
8 years, 7 months ago (2012-05-07 19:24:10 UTC) #1
John Grabowski
LGTM
8 years, 7 months ago (2012-05-07 19:57:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10381043/1
8 years, 7 months ago (2012-05-07 20:52:04 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-07 22:33:26 UTC) #4
Change committed as 135746

Powered by Google App Engine
This is Rietveld 408576698