Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10381038: Roll v8-i18n to r66. (Closed)

Created:
8 years, 7 months ago by Nebojša Ćirić
Modified:
8 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Visibility:
Public.

Description

Roll v8-i18n to r66. This change adds new v8Intl global namespace and new API that reflects the current EcmaScript 402 draft - http://wiki.ecmascript.org/doku.php?id=globalization:specification_drafts. The old v8Locale is still available, so the current users won't notice the addition. License header in collator.h was updated. Some collator extension keys were removed per spec. Code was restructured so it doesn't add three new static initializations to CHrome startup. Memory leaks fixed. BUG=28604 TEST= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
jungshik at Google
LGTM
8 years, 7 months ago (2012-05-07 18:49:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-07 20:44:43 UTC) #2
commit-bot: I haz the power
Try job failure for 10381038-1 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...
8 years, 7 months ago (2012-05-08 00:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-08 04:27:36 UTC) #4
commit-bot: I haz the power
Try job failure for 10381038-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 7 months ago (2012-05-08 08:48:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-08 12:19:30 UTC) #6
commit-bot: I haz the power
Try job failure for 10381038-1 (retry) on win_rel for step "browser_tests" (clobber build). It's a ...
8 years, 7 months ago (2012-05-08 14:05:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-08 16:21:58 UTC) #8
commit-bot: I haz the power
Try job failure for 10381038-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=26953 Step "update" is always ...
8 years, 7 months ago (2012-05-08 16:36:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-08 17:25:44 UTC) #10
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 7 months ago (2012-05-08 23:39:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-08 23:48:40 UTC) #12
commit-bot: I haz the power
Try job failure for 10381038-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=27217 Step "update" is always ...
8 years, 7 months ago (2012-05-09 00:18:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10381038/1
8 years, 7 months ago (2012-05-09 02:20:16 UTC) #14
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 02:20:38 UTC) #15
Change committed as 135972

Powered by Google App Engine
This is Rietveld 408576698