Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3923)

Unified Diff: chrome/browser/protector/default_search_provider_change.cc

Issue 10381016: Remove the "autogenerate keyword" bit on TemplateURL. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/protector/default_search_provider_change.cc
===================================================================
--- chrome/browser/protector/default_search_provider_change.cc (revision 135424)
+++ chrome/browser/protector/default_search_provider_change.cc (working copy)
@@ -53,7 +53,7 @@
if (!url || !other_)
return false;
return url->short_name() == other_->short_name() &&
- AreKeywordsSame(url, other_) &&
+ url->HasSameKeywordAs(*other_) &&
url->url() == other_->url() &&
url->suggestions_url() == other_->suggestions_url() &&
url->instant_url() == other_->instant_url() &&
@@ -65,13 +65,6 @@
}
private:
- // Returns true if both |url1| and |url2| have autogenerated keywords
- // or if their keywords are identical.
- bool AreKeywordsSame(const TemplateURL* url1, const TemplateURL* url2) {
- return (url1->autogenerate_keyword() && url2->autogenerate_keyword()) ||
- url1->keyword() == url2->keyword();
- }
-
const TemplateURL* other_;
};

Powered by Google App Engine
This is Rietveld 408576698