Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10381010: Add initial GTK web accessibility framework (new with valgrind fix). (Closed)

Created:
8 years, 7 months ago by dmazzoni
Modified:
8 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, ctguil+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, penghuang+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, James Su, zork+watch_chromium.org
Visibility:
Public.

Description

Add initial GTK web accessibility framework (new with valgrind fix). This is the same as http://codereview.chromium.org/9839069/ which was landed but reverted due to a valgrind failure in content_unittests. The valgrind failure was because browser_accessibility_manager_unittest.cc is constructing its own subclass of BrowserAccessibility (for testing), but BrowserAccessibilityManagerGtk was assuming that any BrowserAccessibility could be static_casted to a BrowserAccessibilityGtk. I fixed this by making ToBrowserAccessibilityGtk() a virtual method with a default impl that returns NULL. Original change: This enables Linux desktop assistive technology such as the Orca screen reader to access the web contents. Builds on the same accessibility stack used by Mac & Windows already. This change works with Orca now, but it's minimal: all that works is getting the correct feedback when you tab through focusable links and controls in a webpage. Future changes will add the rest of the support. BUG=24585 TEST=Run Chrome on desktop Linux with Orca turned on, tab through links. TBR=darin,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135593

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -92 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 2 3 4 5 2 chunks +9 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 5 2 chunks +19 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 6 7 8 9 6 chunks +10 lines, -7 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_gtk.h View 1 1 chunk +93 lines, -0 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_gtk.cc View 1 2 3 4 5 1 chunk +343 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.mm View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac_unittest.mm View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_manager_gtk.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_manager_gtk.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 2 3 4 5 6 7 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 5 6 7 8 9 26 chunks +50 lines, -49 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 2 3 4 5 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper_mac.mm View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 3 4 5 5 chunks +24 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 5 4 chunks +76 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 5 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/gtk_preserve_window.h View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
M ui/gfx/gtk_preserve_window.cc View 1 2 3 4 5 4 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
8 years, 7 months ago (2012-05-04 16:06:21 UTC) #1
David Tseng
8 years, 7 months ago (2012-05-04 17:39:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698