Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 10381002: Pepper: Make users of pp:NetworkMonitorPrivate less likely to leak resources. (Closed)

Created:
8 years, 7 months ago by viettrungluu
Modified:
8 years, 7 months ago
Reviewers:
Sergey Ulanov, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Make users of pp:NetworkMonitorPrivate less likely to leak resources. a) Make NetworkListPrivate's constructor (that takes a PP_Resource) take ownership of that resource. b) Add an explicit PASS_REF to that constructor, to make its semantics clear. TEST=PPAPI tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135856

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -30 lines) Patch
M ppapi/cpp/private/network_list_private.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/cpp/private/network_list_private.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_network_monitor_private.cc View 6 chunks +7 lines, -23 lines 0 comments Download
M ppapi/utility/private/network_list_observer_private.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
I think this is cleaner and clearer, but it's not a big deal. (I wonder ...
8 years, 7 months ago (2012-05-03 23:26:33 UTC) #1
brettw
lgtm
8 years, 7 months ago (2012-05-03 23:30:28 UTC) #2
viettrungluu
+sergeyu, since apparently I have to update remoting too.
8 years, 7 months ago (2012-05-03 23:58:08 UTC) #3
Sergey Ulanov
lgtm
8 years, 7 months ago (2012-05-04 00:15:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/10381002/7001
8 years, 7 months ago (2012-05-04 17:57:59 UTC) #5
commit-bot: I haz the power
Try job failure for 10381002-7001 (retry) on win for step "runhooks". It's a second try, ...
8 years, 7 months ago (2012-05-04 18:20:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/10381002/7001
8 years, 7 months ago (2012-05-07 20:33:16 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 00:34:54 UTC) #8
Try job failure for 10381002-7001 (retry) (retry) on win_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698