Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 10380019: Stop postponing instantiation of Type and remove InstantiatedType VM class. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 7388)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -283,51 +283,6 @@
}
-RawInstantiatedType* InstantiatedType::ReadFrom(SnapshotReader* reader,
- intptr_t object_id,
- intptr_t tags,
- Snapshot::Kind kind) {
- ASSERT(reader != NULL);
- ASSERT(kind == Snapshot::kMessage);
-
- // Allocate instantiated type object.
- InstantiatedType& instantiated_type =
- InstantiatedType::ZoneHandle(reader->isolate(), InstantiatedType::New());
- reader->AddBackwardReference(object_id, &instantiated_type);
-
- // Set the object tags.
- instantiated_type.set_tags(tags);
-
- // Now set all the object fields.
- // TODO(5411462): Need to assert No GC can happen here, even though
- // allocations may happen.
- intptr_t num_flds = (instantiated_type.raw()->to() -
- instantiated_type.raw()->from());
- for (intptr_t i = 0; i <= num_flds; i++) {
- *(instantiated_type.raw()->from() + i) = reader->ReadObject();
- }
- return instantiated_type.raw();
-}
-
-
-void RawInstantiatedType::WriteTo(SnapshotWriter* writer,
- intptr_t object_id,
- Snapshot::Kind kind) {
- ASSERT(writer != NULL);
- ASSERT(kind == Snapshot::kMessage);
-
- // Write out the serialization header value for this object.
- writer->WriteSerializationMarker(kInlined, object_id);
-
- // Write out the class and tags information.
- writer->WriteObjectHeader(Object::kInstantiatedTypeClass, ptr()->tags_);
-
- // Write out all the object pointer fields.
- SnapshotWriterVisitor visitor(writer);
- visitor.VisitPointers(from(), to());
-}
-
-
RawAbstractTypeArguments* AbstractTypeArguments::ReadFrom(
SnapshotReader* reader,
intptr_t object_id,
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698