Issue 10380018: Revert 135484 - Use Android API for GetDisplayNameForLocale().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10380018: Revert 135484 - Use Android API for GetDisplayNameForLocale(). (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)

Modified:
8 years, 7 months ago

Reviewers:
Xianzhu

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, dyu1, dhollowa+watch_chromium.org, Ilya Sherman, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 135484 - Use Android API for GetDisplayNameForLocale(). failure: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/4835/steps/BuildTarget/logs/stdio Using Android API, we can reduce the data size of ICU and thus reduce the binary size of chromium-android. BUG=none TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry TBR=sky Review URL: http://codereview.chromium.org/10224004 TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135490

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -282 lines)			Patch
D	base/android/java/org/chromium/base/LocaleUtils.java	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	base/android/locale_utils.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	base/android/locale_utils.cc	View	1 chunk	+0 lines, -94 lines	0 comments	Download
M	base/base.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/base.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	build/all_android.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	build/android/gtest_filter/ui_unittests_disabled	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_country.cc	View	7 chunks	+26 lines, -11 lines	0 comments	Download
M	testing/android/native_test_launcher.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ui/base/l10n/l10n_util.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	ui/base/l10n/l10n_util.cc	View	2 chunks	+10 lines, -37 lines	0 comments	Download
M	ui/base/l10n/l10n_util_unittest.cc	View	4 chunks	+2 lines, -19 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	3 chunks	+1 line, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

8 years, 7 months ago (2012-05-05 00:13:04 UTC) #2

On 2012/05/04 23:55:12, rvargas wrote:

LGTM. Thanks.

BTW, could the try server use the same building configuration of the failing
server so that we can notice the problem earlier?

Expand Messages | Collapse Messages