Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 10380015: Now mark delete notifications for archived URLs specially (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/expire_history_backend.cc ('k') | chrome/browser/history/history_notifications.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/expire_history_backend_unittest.cc
diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc
index 2432562b823fd040ec65c97c7cfc33dda0494257..fffc7f1103c76804398b5fabf42ae768033a456a 100644
--- a/chrome/browser/history/expire_history_backend_unittest.cc
+++ b/chrome/browser/history/expire_history_backend_unittest.cc
@@ -382,8 +382,10 @@ void ExpireHistoryTest::EnsureURLInfoGone(const URLRow& row) {
bool found_delete_notification = false;
for (size_t i = 0; i < notifications_.size(); i++) {
if (notifications_[i].first == chrome::NOTIFICATION_HISTORY_URLS_DELETED) {
- const history::URLRows& rows(reinterpret_cast<URLsDeletedDetails*>(
- notifications_[i].second)->rows);
+ URLsDeletedDetails* details = reinterpret_cast<URLsDeletedDetails*>(
+ notifications_[i].second);
+ EXPECT_FALSE(details->archived);
+ const history::URLRows& rows(details->rows);
if (std::find_if(rows.begin(), rows.end(),
history::URLRow::URLRowHasURL(row.url())) != rows.end()) {
found_delete_notification = true;
« no previous file with comments | « chrome/browser/history/expire_history_backend.cc ('k') | chrome/browser/history/history_notifications.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698