Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10380015: Now mark delete notifications for archived URLs specially (Closed)

Created:
8 years, 7 months ago by Andrew T Wilson (Slow)
Modified:
8 years, 7 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Now mark delete notifications for archived URLs specially BUG=124508 TEST=existing tests suffice Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135963

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M chrome/browser/history/expire_history_backend.h View 1 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/history/history_notifications.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history_notifications.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrew T Wilson (Slow)
PTAL. This is the first step towards letting Sync ignore archived URLs (we don't want ...
8 years, 7 months ago (2012-05-04 23:32:34 UTC) #1
sky
I'm passing this one Brett's way.
8 years, 7 months ago (2012-05-04 23:43:39 UTC) #2
brettw
lgtm http://codereview.chromium.org/10380015/diff/1/chrome/browser/history/expire_history_backend.h File chrome/browser/history/expire_history_backend.h (right): http://codereview.chromium.org/10380015/diff/1/chrome/browser/history/expire_history_backend.h#newcode201 chrome/browser/history/expire_history_backend.h:201: USER_INITIATED, Can you prefix these with something. Like ...
8 years, 7 months ago (2012-05-08 19:56:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/10380015/9001
8 years, 7 months ago (2012-05-08 21:26:57 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 00:25:29 UTC) #5
Try job failure for 10380015-9001 (retry) (retry) (retry) on win_rel for step
"update".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698