Revert "Revert "Implement {Int,Uint}{8,16,32,64} and Float{32,64} typed arrays.""

runtime/lib/byte_array.cc

Index: runtime/lib/byte_array.cc
diff --git a/runtime/lib/byte_array.cc b/runtime/lib/byte_array.cc
index 7b76e68c5fafc230a43b1c11baa86941654d2211..f9a993a8e48a87e4a7f23ce898066bd11018d3aa 100644
--- a/runtime/lib/byte_array.cc
+++ b/runtime/lib/byte_array.cc
@@ -11,30 +11,12 @@
 
 namespace dart {
 
-DEFINE_NATIVE_ENTRY(ByteArray_getLength, 1) {
-  const ByteArray& byte_array = ByteArray::CheckedHandle(arguments->At(0));
-  const Smi& length = Smi::Handle(Smi::New(byte_array.Length()));
-  arguments->SetReturn(length);
-}
-
-
-DEFINE_NATIVE_ENTRY(InternalByteArray_allocate, 1) {
-  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
-  if (length.Value() < 0) {
-    GrowableArray<const Object*> args;
-    args.Add(&length);
-    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
-  }
-  const InternalByteArray& new_array =
-      InternalByteArray::Handle(InternalByteArray::New(length.Value()));
-  arguments->SetReturn(new_array);
-}
-
+// ByteArray
 
 static void RangeCheck(const ByteArray& array,
                        intptr_t index,
                        intptr_t num_bytes) {
-  if (!Utils::RangeCheck(index, num_bytes, array.Length())) {
+  if (!Utils::RangeCheck(index, num_bytes, array.ByteLength())) {
     GrowableArray<const Object*> arguments;
     const Smi &index_object = Smi::Handle(Smi::New(index));
     arguments.Add(&index_object);
@@ -43,274 +25,598 @@ static void RangeCheck(const ByteArray& array,
 }
 
 
-DEFINE_NATIVE_ENTRY(ByteArray_setRange, 5) {
-  ByteArray& dst = ByteArray::CheckedHandle(arguments->At(0));
-  GET_NATIVE_ARGUMENT(Smi, dst_start, arguments->At(1));
-  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(2));
-  GET_NATIVE_ARGUMENT(ByteArray, src, arguments->At(3));
-  GET_NATIVE_ARGUMENT(Smi, src_start, arguments->At(4));
-  intptr_t length_value = length.Value();
-  intptr_t src_start_value = src_start.Value();
-  intptr_t dst_start_value = dst_start.Value();
-  if (length_value < 0) {
-    GrowableArray<const Object*> args;
-    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
-  }
-  RangeCheck(src, src_start_value, length_value);
-  RangeCheck(dst, dst_start_value, length_value);
-  ByteArray::Copy(dst, dst_start_value, src, src_start_value, length_value);
-}
-
 #define GETTER_ARGUMENTS(ArrayT, ValueT)                                \
   GET_NATIVE_ARGUMENT(ArrayT, array, arguments->At(0));                 \
-  GET_NATIVE_ARGUMENT(Smi, index, arguments->At(1));                    \
-  RangeCheck(array, index.Value(), sizeof(ValueT));
+  GET_NATIVE_ARGUMENT(Smi, index, arguments->At(1));
 
 
 #define SETTER_ARGUMENTS(ArrayT, ObjectT, ValueT)                       \
   GET_NATIVE_ARGUMENT(ArrayT, array, arguments->At(0));                 \
   GET_NATIVE_ARGUMENT(Smi, index, arguments->At(1));                    \
-  RangeCheck(array, index.Value(), sizeof(ValueT));                     \
-  GET_NATIVE_ARGUMENT(ObjectT, integer_value, arguments->At(2));
+  GET_NATIVE_ARGUMENT(ObjectT, value_object, arguments->At(2));
 
 
 #define GETTER(ArrayT, ObjectT, ValueT)                                 \
   GETTER_ARGUMENTS(ArrayT, ValueT);                                     \
-  ValueT result = array.UnalignedAt<ValueT>(index.Value());             \
+  RangeCheck(array, index.Value() * sizeof(ValueT), sizeof(ValueT));    \
+  ValueT result = array.At(index.Value());                              \
   arguments->SetReturn(ObjectT::Handle(ObjectT::New(result)));
 
 
 #define SETTER(ArrayT, ObjectT, Getter, ValueT)                         \
   SETTER_ARGUMENTS(ArrayT, ObjectT, ValueT);                            \
-  array.SetUnalignedAt<ValueT>(index.Value(), integer_value.Getter());
+  RangeCheck(array, index.Value() * sizeof(ValueT), sizeof(ValueT));    \
+  ValueT value = value_object.Getter();                                \
+  array.SetAt(index.Value(), value);
 
 
-#define GETTER_UINT64(ArrayT)                                           \
-  GETTER_ARGUMENTS(ArrayT, uint64_t);                                   \
-  uint64_t value = array.UnalignedAt<uint64_t>(index.Value());          \
-  Integer& result = Integer::Handle();                                  \
+#define UNALIGNED_GETTER(ArrayT, ObjectT, ValueT)                       \
+  GETTER_ARGUMENTS(ArrayT, ValueT);                                     \
+  RangeCheck(array, index.Value(), sizeof(ValueT));                     \
+  ValueT result;                                                        \
+  ByteArray::Copy(&result, array, index.Value(), sizeof(ValueT));       \
+  arguments->SetReturn(ObjectT::Handle(ObjectT::New(result)));
+
+
+#define UNALIGNED_SETTER(ArrayT, ObjectT, Getter, ValueT)               \
+  SETTER_ARGUMENTS(ArrayT, ObjectT, ValueT);                            \
+  RangeCheck(array, index.Value(), sizeof(ValueT));                     \
+  ValueT src = value_object.Getter();                                  \
+  ByteArray::Copy(array, index.Value(), &src, sizeof(ValueT));
+
+
+#define UINT64_TO_INTEGER(value, integer)                               \
   if (value > static_cast<uint64_t>(Mint::kMaxValue)) {                 \
     result = BigintOperations::NewFromUint64(value);                    \
   } else if (value > static_cast<uint64_t>(Smi::kMaxValue)) {           \
     result = Mint::New(value);                                          \
   } else {                                                              \
     result = Smi::New(value);                                           \
-  }                                                                     \
+  }
+
+
+#define GETTER_UINT64(ArrayT)                                           \
+  GETTER_ARGUMENTS(ArrayT, uint64_t);                                   \
+  intptr_t size = sizeof(uint64_t);                                     \
+  RangeCheck(array, index.Value() * size, size);                        \
+  uint64_t value = array.At(index.Value());                             \
+  Integer& result = Integer::Handle();                                  \
+  UINT64_TO_INTEGER(value, result);                                     \
   arguments->SetReturn(result);
 
 
-#define SETTER_UINT64(ArrayT)                                           \
-  SETTER_ARGUMENTS(ArrayT, Integer, uint64_t);                          \
+#define UNALIGNED_GETTER_UINT64(ArrayT)                                 \
+  GETTER_ARGUMENTS(ArrayT, uint64_t);                                   \
+  RangeCheck(array, index.Value(), sizeof(uint64_t));                   \
   uint64_t value;                                                       \
-  if (integer_value.IsBigint()) {                                       \
-    Bigint& bigint_value = Bigint::Handle();                            \
-    bigint_value ^= integer_value.raw();                                \
-    ASSERT(BigintOperations::FitsIntoUint64(bigint_value));             \
-    value = BigintOperations::AbsToUint64(bigint_value);                \
+  ByteArray::Copy(&value, array, index.Value(), sizeof(uint64_t));      \
+  Integer& result = Integer::Handle();                                  \
+  UINT64_TO_INTEGER(value, result);                                     \
+  arguments->SetReturn(result);
+
+
+#define INTEGER_TO_UINT64(integer, uint64)                              \
+  if (integer.IsBigint()) {                                             \
+    Bigint& bigint = Bigint::Handle();                                  \
+    bigint ^= integer.raw();                                            \
+    ASSERT(BigintOperations::FitsIntoUint64(bigint));                   \
+    value = BigintOperations::AbsToUint64(bigint);                      \
   } else {                                                              \
-    ASSERT(integer_value.IsMint() || integer_value.IsSmi());            \
-    value = integer_value.AsInt64Value();                               \
+    ASSERT(integer.IsMint() || integer.IsSmi());                        \
+    value = integer.AsInt64Value();                                     \
   }                                                                     \
-  array.SetUnalignedAt<uint64_t>(index.Value(), value);
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getInt8, 2) {
-  GETTER(InternalByteArray, Smi, int8_t);
+#define SETTER_UINT64(ArrayT)                                           \
+  SETTER_ARGUMENTS(ArrayT, Integer, uint64_t);                          \
+  intptr_t size = sizeof(uint64_t);                                     \
+  RangeCheck(array, index.Value() * size, size);                        \
+  uint64_t value;                                                       \
+  INTEGER_TO_UINT64(value_object, value);                               \
+  array.SetAt(index.Value(), value);
+
+
+#define UNALIGNED_SETTER_UINT64(ArrayT)                                 \
+  SETTER_ARGUMENTS(ArrayT, Integer, uint64_t);                          \
+  RangeCheck(array, index.Value(), sizeof(uint64_t));                   \
+  uint64_t value;                                                       \
+  INTEGER_TO_UINT64(value_object, value);                               \
+  ByteArray::Copy(array, index.Value(), &value, sizeof(uint64_t));
+
+
+DEFINE_NATIVE_ENTRY(ByteArray_getLength, 1) {
+  GET_NATIVE_ARGUMENT(ByteArray, array, arguments->At(0));
+  const Smi& length = Smi::Handle(Smi::New(array.Length()));
+  arguments->SetReturn(length);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setInt8, 3) {
-  SETTER(InternalByteArray, Smi, Value, int8_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getInt8, 2) {
+  UNALIGNED_GETTER(ByteArray, Smi, int8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getUint8, 2) {
-  GETTER(InternalByteArray, Smi, uint8_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setInt8, 3) {
+  UNALIGNED_SETTER(ByteArray, Smi, Value, int8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setUint8, 3) {
-  SETTER(InternalByteArray, Smi, Value, uint8_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getUint8, 2) {
+  UNALIGNED_GETTER(ByteArray, Smi, uint8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getInt16, 2) {
-  GETTER(InternalByteArray, Smi, int16_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setUint8, 3) {
+  UNALIGNED_SETTER(ByteArray, Smi, Value, uint8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setInt16, 3) {
-  SETTER(InternalByteArray, Smi, Value, int16_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getInt16, 2) {
+  UNALIGNED_GETTER(ByteArray, Smi, int16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getUint16, 2) {
-  GETTER(InternalByteArray, Smi, uint16_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setInt16, 3) {
+  UNALIGNED_SETTER(ByteArray, Smi, Value, int16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setUint16, 3) {
-  SETTER(InternalByteArray, Smi, Value, uint16_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getUint16, 2) {
+  UNALIGNED_GETTER(ByteArray, Smi, uint16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getInt32, 2) {
-  GETTER(InternalByteArray, Integer, int32_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setUint16, 3) {
+  UNALIGNED_SETTER(ByteArray, Smi, Value, uint16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setInt32, 3) {
-  SETTER(InternalByteArray, Integer, AsInt64Value, int32_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getInt32, 2) {
+  UNALIGNED_GETTER(ByteArray, Integer, int32_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getUint32, 2) {
-  GETTER(InternalByteArray, Integer, uint32_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setInt32, 3) {
+  UNALIGNED_SETTER(ByteArray, Integer, AsInt64Value, int32_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setUint32, 3) {
-  SETTER(InternalByteArray, Integer, AsInt64Value, uint32_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getUint32, 2) {
+  UNALIGNED_GETTER(ByteArray, Integer, uint32_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getInt64, 2) {
-  GETTER(InternalByteArray, Integer, int64_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setUint32, 3) {
+  UNALIGNED_SETTER(ByteArray, Integer, AsInt64Value, uint32_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setInt64, 3) {
-  SETTER(InternalByteArray, Integer, AsInt64Value, int64_t);
+DEFINE_NATIVE_ENTRY(ByteArray_getInt64, 2) {
+  UNALIGNED_GETTER(ByteArray, Integer, int64_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getUint64, 2) {
-  GETTER_UINT64(InternalByteArray);
+DEFINE_NATIVE_ENTRY(ByteArray_setInt64, 3) {
+  UNALIGNED_SETTER(ByteArray, Integer, AsInt64Value, int64_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setUint64, 3) {
-  SETTER_UINT64(InternalByteArray);
+DEFINE_NATIVE_ENTRY(ByteArray_getUint64, 2) {
+  UNALIGNED_GETTER_UINT64(ByteArray);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getFloat32, 2) {
-  GETTER(InternalByteArray, Double, float);
+DEFINE_NATIVE_ENTRY(ByteArray_setUint64, 3) {
+  UNALIGNED_SETTER_UINT64(ByteArray);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setFloat32, 3) {
-  SETTER(InternalByteArray, Double, value, float);
+DEFINE_NATIVE_ENTRY(ByteArray_getFloat32, 2) {
+  UNALIGNED_GETTER(ByteArray, Double, float);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_getFloat64, 2) {
-  GETTER(InternalByteArray, Double, double);
+DEFINE_NATIVE_ENTRY(ByteArray_setFloat32, 3) {
+  UNALIGNED_SETTER(ByteArray, Double, value, float);
 }
 
 
-DEFINE_NATIVE_ENTRY(InternalByteArray_setFloat64, 3) {
-  SETTER(InternalByteArray, Double, value, double);
+DEFINE_NATIVE_ENTRY(ByteArray_getFloat64, 2) {
+  UNALIGNED_GETTER(ByteArray, Double, double);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getInt8, 2) {
-  GETTER(ExternalByteArray, Smi, int8_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setFloat64, 3) {
+  UNALIGNED_SETTER(ByteArray, Double, value, double);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setInt8, 3) {
-  SETTER(ExternalByteArray, Smi, Value, int8_t);
+DEFINE_NATIVE_ENTRY(ByteArray_setRange, 5) {
+  ByteArray& dst = ByteArray::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(Smi, dst_start, arguments->At(1));
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(2));
+  GET_NATIVE_ARGUMENT(ByteArray, src, arguments->At(3));
+  GET_NATIVE_ARGUMENT(Smi, src_start, arguments->At(4));
+  intptr_t length_value = length.Value();
+  intptr_t src_start_value = src_start.Value();
+  intptr_t dst_start_value = dst_start.Value();
+  if (length_value < 0) {
+    GrowableArray<const Object*> args;
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  RangeCheck(src, src_start_value, length_value);
+  RangeCheck(dst, dst_start_value, length_value);
+  ByteArray::Copy(dst, dst_start_value, src, src_start_value, length_value);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getUint8, 2) {
-  GETTER(ExternalByteArray, Smi, uint8_t);
+// Int8Array
+
+DEFINE_NATIVE_ENTRY(Int8Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Int8Array& new_array =
+      Int8Array::Handle(Int8Array::New(length.Value()));
+  arguments->SetReturn(new_array);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setUint8, 3) {
-  SETTER(ExternalByteArray, Smi, Value, uint8_t);
+DEFINE_NATIVE_ENTRY(Int8Array_getIndexed, 2) {
+  GETTER(Int8Array, Smi, int8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getInt16, 2) {
-  GETTER(ExternalByteArray, Smi, int16_t);
+DEFINE_NATIVE_ENTRY(Int8Array_setIndexed, 3) {
+  SETTER(Int8Array, Smi, Value, int8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setInt16, 3) {
-  SETTER(ExternalByteArray, Smi, Value, int16_t);
+// Uint8Array
+
+DEFINE_NATIVE_ENTRY(Uint8Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Uint8Array& new_array =
+      Uint8Array::Handle(Uint8Array::New(length.Value()));
+  arguments->SetReturn(new_array);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getUint16, 2) {
-  GETTER(ExternalByteArray, Smi, uint16_t);
+DEFINE_NATIVE_ENTRY(Uint8Array_getIndexed, 2) {
+  GETTER(Uint8Array, Smi, uint8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setUint16, 3) {
-  SETTER(ExternalByteArray, Smi, Value, uint16_t);
+DEFINE_NATIVE_ENTRY(Uint8Array_setIndexed, 3) {
+  SETTER(Uint8Array, Smi, Value, uint8_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getInt32, 2) {
-  GETTER(ExternalByteArray, Integer, int32_t);
+// Int16Array
+
+DEFINE_NATIVE_ENTRY(Int16Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Int16Array& new_array =
+      Int16Array::Handle(Int16Array::New(length.Value()));
+  arguments->SetReturn(new_array);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setInt32, 3) {
-  SETTER(ExternalByteArray, Integer, AsInt64Value, int32_t);
+DEFINE_NATIVE_ENTRY(Int16Array_getIndexed, 2) {
+  GETTER(Int16Array, Smi, int16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getUint32, 2) {
-  GETTER(ExternalByteArray, Integer, uint32_t);
+DEFINE_NATIVE_ENTRY(Int16Array_setIndexed, 3) {
+  SETTER(Int16Array, Smi, Value, int16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setUint32, 3) {
-  SETTER(ExternalByteArray, Integer, AsInt64Value, uint32_t);
+// Uint16Array
+
+DEFINE_NATIVE_ENTRY(Uint16Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Uint16Array& new_array =
+      Uint16Array::Handle(Uint16Array::New(length.Value()));
+  arguments->SetReturn(new_array);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getInt64, 2) {
-  GETTER(ExternalByteArray, Integer, int64_t);
+DEFINE_NATIVE_ENTRY(Uint16Array_getIndexed, 2) {
+  GETTER(Uint16Array, Smi, uint16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setInt64, 3) {
-  SETTER(ExternalByteArray, Integer, AsInt64Value, int64_t);
+DEFINE_NATIVE_ENTRY(Uint16Array_setIndexed, 3) {
+  SETTER(Uint16Array, Smi, Value, uint16_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getUint64, 2) {
-  GETTER_UINT64(ExternalByteArray);
+// Int32Array
+
+DEFINE_NATIVE_ENTRY(Int32Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Int32Array& new_array =
+      Int32Array::Handle(Int32Array::New(length.Value()));
+  arguments->SetReturn(new_array);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setUint64, 3) {
-  SETTER_UINT64(ExternalByteArray);
+DEFINE_NATIVE_ENTRY(Int32Array_getIndexed, 2) {
+  GETTER(Int32Array, Integer, int32_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getFloat32, 2) {
-  GETTER(ExternalByteArray, Double, float);
+DEFINE_NATIVE_ENTRY(Int32Array_setIndexed, 3) {
+  SETTER(Int32Array, Integer, AsInt64Value, int32_t);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setFloat32, 3) {
-  SETTER(ExternalByteArray, Double, value, float);
+// Uint32Array
+
+DEFINE_NATIVE_ENTRY(Uint32Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Uint32Array& new_array =
+      Uint32Array::Handle(Uint32Array::New(length.Value()));
+  arguments->SetReturn(new_array);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_getFloat64, 2) {
-  GETTER(ExternalByteArray, Double, double);
+DEFINE_NATIVE_ENTRY(Uint32Array_getIndexed, 2) {
+  GETTER(Uint32Array, Integer, uint32_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(Uint32Array_setIndexed, 3) {
+  SETTER(Uint32Array, Integer, AsInt64Value, uint32_t);
+}
+
+
+// Int64Array
+
+DEFINE_NATIVE_ENTRY(Int64Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Int64Array& new_array =
+      Int64Array::Handle(Int64Array::New(length.Value()));
+  arguments->SetReturn(new_array);
+}
+
+
+DEFINE_NATIVE_ENTRY(Int64Array_getIndexed, 2) {
+  GETTER(Int64Array, Integer, int64_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(Int64Array_setIndexed, 3) {
+  SETTER(Int64Array, Integer, AsInt64Value, int64_t);
+}
+
+
+// Uint64Array
+
+DEFINE_NATIVE_ENTRY(Uint64Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Uint64Array& new_array =
+      Uint64Array::Handle(Uint64Array::New(length.Value()));
+  arguments->SetReturn(new_array);
+}
+
+
+DEFINE_NATIVE_ENTRY(Uint64Array_getIndexed, 2) {
+  GETTER_UINT64(Uint64Array);
+}
+
+
+DEFINE_NATIVE_ENTRY(Uint64Array_setIndexed, 3) {
+  SETTER_UINT64(Uint64Array);
+}
+
+
+// Float32Array
+
+DEFINE_NATIVE_ENTRY(Float32Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Float32Array& new_array =
+      Float32Array::Handle(Float32Array::New(length.Value()));
+  arguments->SetReturn(new_array);
+}
+
+
+DEFINE_NATIVE_ENTRY(Float32Array_getIndexed, 2) {
+  GETTER(Float32Array, Double, float);
+}
+
+
+DEFINE_NATIVE_ENTRY(Float32Array_setIndexed, 3) {
+  SETTER(Float32Array, Double, value, float);
+}
+
+
+// Float64Array
+
+DEFINE_NATIVE_ENTRY(Float64Array_new, 1) {
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
+  if (length.Value() < 0) {
+    GrowableArray<const Object*> args;
+    args.Add(&length);
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  const Float64Array& new_array =
+      Float64Array::Handle(Float64Array::New(length.Value()));
+  arguments->SetReturn(new_array);
+}
+
+
+DEFINE_NATIVE_ENTRY(Float64Array_getIndexed, 2) {
+  GETTER(Float64Array, Double, double);
+}
+
+
+DEFINE_NATIVE_ENTRY(Float64Array_setIndexed, 3) {
+  SETTER(Float64Array, Double, value, double);
+}
+
+
+// ExternalInt8Array
+
+DEFINE_NATIVE_ENTRY(ExternalInt8Array_getIndexed, 2) {
+  GETTER(ExternalInt8Array, Smi, int8_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalInt8Array_setIndexed, 3) {
+  SETTER(ExternalInt8Array, Smi, Value, int8_t);
+}
+
+
+// ExternalUint8Array
+
+DEFINE_NATIVE_ENTRY(ExternalUint8Array_getIndexed, 2) {
+  UNALIGNED_GETTER(ExternalUint8Array, Smi, uint8_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalUint8Array_setIndexed, 3) {
+  UNALIGNED_SETTER(ExternalUint8Array, Smi, Value, uint8_t);
+}
+
+
+// ExternalInt16Array
+
+DEFINE_NATIVE_ENTRY(ExternalInt16Array_getIndexed, 2) {
+  GETTER(ExternalInt16Array, Smi, int16_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalInt16Array_setIndexed, 3) {
+  SETTER(ExternalInt16Array, Smi, Value, int16_t);
+}
+
+
+// ExternalUint16Array
+
+DEFINE_NATIVE_ENTRY(ExternalUint16Array_getIndexed, 2) {
+  UNALIGNED_GETTER(ExternalUint16Array, Smi, uint16_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalUint16Array_setIndexed, 3) {
+  UNALIGNED_SETTER(ExternalUint16Array, Smi, Value, uint16_t);
+}
+
+
+// ExternalInt32Array
+
+DEFINE_NATIVE_ENTRY(ExternalInt32Array_getIndexed, 2) {
+  GETTER(ExternalInt32Array, Integer, int32_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalInt32Array_setIndexed, 3) {
+  SETTER(ExternalInt32Array, Integer, AsInt64Value, int32_t);
+}
+
+
+// ExternalUint32Array
+
+DEFINE_NATIVE_ENTRY(ExternalUint32Array_getIndexed, 2) {
+  UNALIGNED_GETTER(ExternalUint32Array, Integer, uint32_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalUint32Array_setIndexed, 3) {
+  UNALIGNED_SETTER(ExternalUint32Array, Integer, AsInt64Value, uint32_t);
+}
+
+
+// ExternalInt64Array
+
+DEFINE_NATIVE_ENTRY(ExternalInt64Array_getIndexed, 2) {
+  GETTER(ExternalInt64Array, Integer, int64_t);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalInt64Array_setIndexed, 3) {
+  SETTER(ExternalInt64Array, Integer, AsInt64Value, int64_t);
+}
+
+
+// ExternalUint64Array
+
+DEFINE_NATIVE_ENTRY(ExternalUint64Array_getIndexed, 2) {
+  GETTER_UINT64(ExternalUint64Array);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalUint64Array_setIndexed, 3) {
+  SETTER_UINT64(ExternalUint64Array);
+}
+
+
+// ExternalFloat32Array
+
+DEFINE_NATIVE_ENTRY(ExternalFloat32Array_getIndexed, 2) {
+  GETTER(ExternalFloat32Array, Double, float);
+}
+
+
+DEFINE_NATIVE_ENTRY(ExternalFloat32Array_setIndexed, 3) {
+  SETTER(ExternalFloat32Array, Double, value, float);
+}
+
+
+// ExternalFloat64Array
+
+DEFINE_NATIVE_ENTRY(ExternalFloat64Array_getIndexed, 2) {
+  GETTER(ExternalFloat64Array, Double, double);
 }
 
 
-DEFINE_NATIVE_ENTRY(ExternalByteArray_setFloat64, 3) {
-  SETTER(ExternalByteArray, Double, value, double);
+DEFINE_NATIVE_ENTRY(ExternalFloat64Array_setIndexed, 3) {
+  SETTER(ExternalFloat64Array, Double, value, double);
 }
 
 }  // namespace dart