Revert "Revert "Implement {Int,Uint}{8,16,32,64} and Float{32,64} typed arrays.""

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 414 matching lines @@
     return false;
   }
   __ movl(EAX, Address(ESP, + 2 * kWordSize));
   __ movl(EBX, Address(ESP, + 1 * kWordSize));
   __ movl(FieldAddress(EAX, GrowableObjectArray::data_offset()), EBX);
   __ ret();
   return true;
 }
 
 
-// Handles only class InternalByteArray.
-bool Intrinsifier::ByteArrayBase_getLength(Assembler* assembler) {
-  ObjectStore* object_store = Isolate::Current()->object_store();
-  Label fall_through;
-  __ movl(EAX, Address(ESP, + 1 * kWordSize));
-  __ movl(EBX, FieldAddress(EAX, Object::class_offset()));
-  __ CompareObject(EBX,
-      Class::ZoneHandle(object_store->internal_byte_array_class()));
-  __ j(NOT_EQUAL, &fall_through);
-  __ movl(EAX, FieldAddress(EAX, InternalByteArray::length_offset()));
-  __ ret();
-  __ Bind(&fall_through);
-  return false;
-}
-
-
-// Handles only class InternalByteArray.
-bool Intrinsifier::ByteArrayBase_getIndexed(Assembler* assembler) {
-  ObjectStore* object_store = Isolate::Current()->object_store();
-  Label fall_through;
-  __ movl(EAX, Address(ESP, + 2 * kWordSize));  // Array.
-  __ movl(EBX, FieldAddress(EAX, Object::class_offset()));
-  __ CompareObject(EBX,
-      Class::ZoneHandle(object_store->internal_byte_array_class()));
-  __ j(NOT_EQUAL, &fall_through);
-  __ movl(EBX, Address(ESP, + 1 * kWordSize));  // Index.
-  __ testl(EBX, Immediate(kSmiTagMask));
-  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
-  // Range check.
-  __ cmpl(EBX, FieldAddress(EAX, InternalByteArray::length_offset()));
-  // Runtime throws exception.
-  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
-  __ SmiUntag(EBX);
-  __ movzxb(EAX,
-      FieldAddress(EAX, EBX, TIMES_1, InternalByteArray::data_offset()));
-  // The values stored in the byte array are regular, untagged values,
-  // therefore they need to be tagged.
-  __ SmiTag(EAX);
-  __ ret();
-  __ Bind(&fall_through);
-  return false;
-}
-
-
 // Tests if two top most arguments are smis, jumps to label not_smi if not.
 // Topmost argument is in EAX.
 static void TestBothArgumentsSmis(Assembler* assembler, Label* not_smi) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ movl(EBX, Address(ESP, + 2 * kWordSize));
   __ orl(EBX, EAX);
   __ testl(EBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, not_smi, Assembler::kNearJump);
 }
 
@@ skipping 848 matching lines @@
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32