Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 10378118: [Chrome OS ECHO]: Update CSP for using the production Google API access point. (Closed)

Created:
8 years, 7 months ago by gauravsh
Modified:
8 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Chrome OS ECHO]: Update CSP for using the production Google API access point. BUG=chromium-os:29809 TEST=tested with corresponding extension change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/chromeos/echo/manifest.json View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gauravsh
8 years, 7 months ago (2012-05-12 00:24:07 UTC) #1
Jorge Lucangeli Obes
LGTM You'll need a full committer as well.
8 years, 7 months ago (2012-05-14 14:29:53 UTC) #2
gauravsh
Zel/Xiyuan: This manifest change needs a full committer's blessing. Thanks!
8 years, 7 months ago (2012-05-14 23:24:38 UTC) #3
xiyuan
rubber stamp LGTM
8 years, 7 months ago (2012-05-14 23:30:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/10378118/1
8 years, 7 months ago (2012-05-15 17:53:25 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 19:47:58 UTC) #6
Change committed as 137208

Powered by Google App Engine
This is Rietveld 408576698