Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: chrome/browser/ui/views/browser_actions_container_browsertest.cc

Issue 10378117: With enable-action-box add extensions to BrowserActionContainer only if they have preference kBrows… (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/browser_action_test_util.h" 5 #include "chrome/browser/extensions/browser_action_test_util.h"
6 #include "chrome/browser/extensions/extension_browsertest.h" 6 #include "chrome/browser/extensions/extension_browsertest.h"
7 #include "chrome/browser/extensions/extension_service.h" 7 #include "chrome/browser/extensions/extension_service.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/views/browser_actions_container.h" 10 #include "chrome/browser/ui/views/browser_actions_container.h"
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("api_test") 226 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("api_test")
227 .AppendASCII("browser_action") 227 .AppendASCII("browser_action")
228 .AppendASCII("basics"))); 228 .AppendASCII("basics")));
229 EXPECT_EQ(1, browser_actions_bar()->NumberOfBrowserActions()); 229 EXPECT_EQ(1, browser_actions_bar()->NumberOfBrowserActions());
230 EnsureExtensionHasIcon(0); 230 EnsureExtensionHasIcon(0);
231 EXPECT_EQ(1, browser_actions_bar()->VisibleBrowserActions()); 231 EXPECT_EQ(1, browser_actions_bar()->VisibleBrowserActions());
232 std::string idA = browser_actions_bar()->GetExtensionId(0); 232 std::string idA = browser_actions_bar()->GetExtensionId(0);
233 233
234 // Force hide this browser action. 234 // Force hide this browser action.
235 ExtensionService* service = browser()->profile()->GetExtensionService(); 235 ExtensionService* service = browser()->profile()->GetExtensionService();
236 service->SetBrowserActionVisibility(service->GetExtensionById(idA, false), 236 service->extension_prefs()->SetBrowserActionVisibility(
237 false); 237 service->GetExtensionById(idA, false), false);
238 EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions()); 238 EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions());
239 239
240 ReloadExtension(idA); 240 ReloadExtension(idA);
241 241
242 // The browser action should become visible again. 242 // The browser action should become visible again.
243 EXPECT_EQ(1, browser_actions_bar()->VisibleBrowserActions()); 243 EXPECT_EQ(1, browser_actions_bar()->VisibleBrowserActions());
244 } 244 }
245 245
246 IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, TestCrash57536) { 246 IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, TestCrash57536) {
247 LOG(INFO) << "Test starting\n" << std::flush; 247 LOG(INFO) << "Test starting\n" << std::flush;
(...skipping 24 matching lines...) Expand all
272 extension->GetResource(extension->browser_action()->default_icon_path()), 272 extension->GetResource(extension->browser_action()->default_icon_path()),
273 bitmap, 273 bitmap,
274 size); 274 size);
275 275
276 LOG(INFO) << "Disabling extension\n" << std::flush; 276 LOG(INFO) << "Disabling extension\n" << std::flush;
277 DisableExtension(extension->id()); 277 DisableExtension(extension->id());
278 LOG(INFO) << "Enabling extension\n" << std::flush; 278 LOG(INFO) << "Enabling extension\n" << std::flush;
279 EnableExtension(extension->id()); 279 EnableExtension(extension->id());
280 LOG(INFO) << "Test ending\n" << std::flush; 280 LOG(INFO) << "Test ending\n" << std::flush;
281 } 281 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698