Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: runtime/vm/object.cc

Issue 10378093: Adding collected type feedback to the IL nodes (only in optimized mode). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 7505)
+++ runtime/vm/object.cc (working copy)
@@ -6218,7 +6218,7 @@
}
-void Code::ExtractIcDataArraysAtCalls(
+intptr_t Code::ExtractIcDataArraysAtCalls(
GrowableArray<intptr_t>* node_ids,
const GrowableObjectArray& ic_data_objs) const {
ASSERT(node_ids != NULL);
@@ -6226,13 +6226,19 @@
const PcDescriptors& descriptors =
PcDescriptors::Handle(this->pc_descriptors());
ICData& ic_data_obj = ICData::Handle();
+ intptr_t max_id = -1;
for (intptr_t i = 0; i < descriptors.Length(); i++) {
if (descriptors.DescriptorKind(i) == PcDescriptors::kIcCall) {
- node_ids->Add(descriptors.NodeId(i));
+ intptr_t node_id = descriptors.NodeId(i);
+ if (node_id > max_id) {
+ max_id = node_id;
+ }
+ node_ids->Add(node_id);
ic_data_obj = CodePatcher::GetInstanceCallIcDataAt(descriptors.PC(i));
ic_data_objs.Add(ic_data_obj);
}
}
+ return max_id;
}
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698