Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8110)

Unified Diff: chrome/browser/ui/views/user_data_dir_dialog.cc

Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix review Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/update_recommended_message_box.cc ('k') | ui/views/controls/message_box_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/user_data_dir_dialog.cc
diff --git a/chrome/browser/ui/views/user_data_dir_dialog.cc b/chrome/browser/ui/views/user_data_dir_dialog.cc
index da053544f9749906dec91a2e277550b3427cbcd6..430f43bda8a39d91c6d676533aadf87da6e0cfce 100644
--- a/chrome/browser/ui/views/user_data_dir_dialog.cc
+++ b/chrome/browser/ui/views/user_data_dir_dialog.cc
@@ -15,24 +15,21 @@
FilePath UserDataDirDialog::RunUserDataDirDialog(
const FilePath& user_data_dir) {
// When the window closes, it will delete itself.
- UserDataDirDialog* dlg = new UserDataDirDialog(user_data_dir);
- MessageLoopForUI::current()->RunWithDispatcher(dlg);
- return dlg->user_data_dir();
+ UserDataDirDialog* dialog = new UserDataDirDialog(user_data_dir);
+ MessageLoopForUI::current()->RunWithDispatcher(dialog);
+ return dialog->user_data_dir();
}
UserDataDirDialog::UserDataDirDialog(const FilePath& user_data_dir)
: ALLOW_THIS_IN_INITIALIZER_LIST(
select_file_dialog_(SelectFileDialog::Create(this))),
is_blocking_(true) {
- string16 message_text = l10n_util::GetStringFUTF16(
- IDS_CANT_WRITE_USER_DIRECTORY_SUMMARY,
- user_data_dir.LossyDisplayName());
const int kDialogWidth = 400;
- message_box_view_ = new views::MessageBoxView(
- views::MessageBoxView::NO_OPTIONS,
- message_text,
- string16(),
- kDialogWidth);
+ views::MessageBoxView::InitParams params(
+ l10n_util::GetStringFUTF16(IDS_CANT_WRITE_USER_DIRECTORY_SUMMARY,
+ user_data_dir.LossyDisplayName()));
+ params.message_width = kDialogWidth;
+ message_box_view_ = new views::MessageBoxView(params);
views::Widget::CreateWindow(this)->Show();
}
« no previous file with comments | « chrome/browser/ui/views/update_recommended_message_box.cc ('k') | ui/views/controls/message_box_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698