Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3116)

Unified Diff: chrome/browser/chromeos/external_protocol_dialog.cc

Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix review Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/download/download_in_progress_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/external_protocol_dialog.cc b/chrome/browser/chromeos/external_protocol_dialog.cc
index 21399d442f74d3344363e0d675a2684d6a2dee24..d8417ae5cf767211947ba30a6d32c6134eb967c1 100644
--- a/chrome/browser/chromeos/external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/external_protocol_dialog.cc
@@ -98,16 +98,12 @@ ExternalProtocolDialog::ExternalProtocolDialog(WebContents* web_contents,
ui::ElideString(ASCIIToUTF16(url.possibly_invalid_spec()),
kMaxUrlWithoutSchemeSize, &elided_url_without_scheme);
- string16 message_text = l10n_util::GetStringFUTF16(
- IDS_EXTERNAL_PROTOCOL_INFORMATION,
+ views::MessageBoxView::InitParams params(
+ l10n_util::GetStringFUTF16(IDS_EXTERNAL_PROTOCOL_INFORMATION,
ASCIIToUTF16(url.scheme() + ":"),
- elided_url_without_scheme) + ASCIIToUTF16("\n\n");
-
- message_box_view_ = new views::MessageBoxView(
- views::MessageBoxView::NO_OPTIONS,
- message_text,
- string16(),
- kMessageWidth);
+ elided_url_without_scheme) + ASCIIToUTF16("\n\n"));
+ params.message_width = kMessageWidth;
+ message_box_view_ = new views::MessageBoxView(params);
message_box_view_->SetCheckBoxLabel(
l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT));
« no previous file with comments | « no previous file | chrome/browser/ui/views/download/download_in_progress_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698