Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: ui/views/controls/message_box_view.cc

Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: InitParams Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/message_box_view.cc
diff --git a/ui/views/controls/message_box_view.cc b/ui/views/controls/message_box_view.cc
index affe912912c9271542bb1a1695491dc32c037f5d..1304512971a10b5c8ed3fbc9d7328a6fcc56b8d9 100644
--- a/ui/views/controls/message_box_view.cc
+++ b/ui/views/controls/message_box_view.cc
@@ -21,10 +21,10 @@
#include "ui/views/widget/widget.h"
#include "ui/views/window/client_view.h"
-const int kDefaultMessageWidth = 320;
-
namespace {
+const int kDefaultMessageWidth = 320;
+
// Paragraph separators are defined in
// http://www.unicode.org/Public/6.0.0/ucd/extracted/DerivedBidiClass.txt
//
@@ -96,25 +96,18 @@ namespace views {
///////////////////////////////////////////////////////////////////////////////
// MessageBoxView, public:
-MessageBoxView::MessageBoxView(int options,
- const string16& message,
- const string16& default_prompt,
- int message_width)
- : prompt_field_(NULL),
- icon_(NULL),
- checkbox_(NULL),
- message_width_(message_width) {
- Init(options, message, default_prompt);
+MessageBoxView::InitParams::InitParams(const string16& message)
+ : options(NO_OPTIONS),
+ message(message),
+ message_width(kDefaultMessageWidth) {
}
-MessageBoxView::MessageBoxView(int options,
- const string16& message,
- const string16& default_prompt)
+MessageBoxView::MessageBoxView(const InitParams& params)
: prompt_field_(NULL),
icon_(NULL),
checkbox_(NULL),
- message_width_(kDefaultMessageWidth) {
- Init(options, message, default_prompt);
+ message_width_(params.message_width) {
+ Init(params.options, params.message, params.default_prompt);
sky 2012/05/11 17:31:10 Pass InitParams to Init.
tfarina 2012/05/11 17:41:42 Done.
}
MessageBoxView::~MessageBoxView() {}

Powered by Google App Engine
This is Rietveld 408576698