Issue 10378081: Merge 135966 - linux: Fix grabs for popups belonging to inactive tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10378081: Merge 135966 - linux: Fix grabs for popups belonging to inactive tabs. (Closed)

Created:
8 years, 7 months ago by Daniel Erat

Modified:
8 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Merge 135966 - linux: Fix grabs for popups belonging to inactive tabs. When displaying a popup for an inactive tab, grab input on behalf of the popup's window rather than its parent window. Also removes window-group code that doesn't make sense to me here (the popup wants all input rather than just input for a subset of browser windows, as shown by the way that it's doing X grabs). BUG=126296 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10380044 TBR=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136173

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View		1 chunk	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages