Issue 10378070: ash: Separate out SystemTrayBubble and related classes into a new file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10378070: ash: Separate out SystemTrayBubble and related classes into a new file. (Closed)

Created:
8 years, 7 months ago by sadrul

Modified:
8 years, 7 months ago

Reviewers:
stevenjb, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, stevenjb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Separate out SystemTrayBubble and related classes into a new file. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136156

Patch Set 1 #

Patch Set 2 : merge #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+656 lines, -592 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1	4 chunks	+1 line, -592 lines	0 comments	Download
A	ash/system/tray/system_tray_bubble.h	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
A	ash/system/tray/system_tray_bubble.cc	View	1	1 chunk	+525 lines, -0 lines	0 comments	Download
M	ash/system/tray/tray_constants.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/system/tray/tray_constants.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

8 years, 7 months ago (2012-05-09 18:47:04 UTC) #3

Please make sure this gets rebased with the changes from
http://codereview.chromium.org/10383045/, and that the changes to
SystemTrayBubble, SystemTrayBubbleView, and SystemTrayBubbleBorder make the
migration.
(CL is (still) in the CQ, sigh...)

Expand Messages | Collapse Messages