Issue 10378064: Revert 135972 - Roll v8-i18n to r66.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10378064: Revert 135972 - Roll v8-i18n to r66. (Closed)

Created:
8 years, 7 months ago by Nebojša Ćirić

Modified:
8 years, 7 months ago

Reviewers:
Nebojša Ćirić

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 135972 - Roll v8-i18n to r66. The change breaks Linux builder wrt. sizes. Reverting till tomorrow. This change adds new v8Intl global namespace and new API that reflects the current EcmaScript 402 draft - http://wiki.ecmascript.org/doku.php?id=globalization:specification_drafts. The old v8Locale is still available, so the current users won't notice the addition. License header in collator.h was updated. Some collator extension keys were removed per spec. Code was restructured so it doesn't add three new static initializations to CHrome startup. Memory leaks fixed. BUG=28604 TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10381038 TBR=cira@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135976

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Nebojša Ćirić

8 years, 7 months ago (2012-05-09 02:49:32 UTC) #2

On 2012/05/09 02:45:53, Nebojša Ćirić wrote:

LGTM