Issue 10378047: Fix bad precedence for >>> operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10378047: Fix bad precedence for >>> operator. (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bad precedence for >>> operator. We use >>> to get positive bit-operations. However the precedence framework was used incorrectly leading to missed parenthesis. Committed: https://code.google.com/p/dart/source/detail?r=7414

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	tests/language/positive_bit_operations_test.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages