Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: chrome/browser/history/history_backend_unittest.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: k Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend_unittest.cc
diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc
index d3f6f0b5e2d14da33fcedd6f1fb99677ebb0c3ea..c3e0884712043c38d7a6a316457f745602fbf543 100644
--- a/chrome/browser/history/history_backend_unittest.cc
+++ b/chrome/browser/history/history_backend_unittest.cc
@@ -346,16 +346,19 @@ TEST_F(HistoryBackendTest, DeleteAll) {
// Add thumbnails for each page. The |Images| take ownership of SkBitmap
// created from decoding the images.
ThumbnailScore score(0.25, true, true);
- gfx::Image google_bitmap(
+ scoped_ptr<SkBitmap> google_bitmap(
gfx::JPEGCodec::Decode(kGoogleThumbnail, sizeof(kGoogleThumbnail)));
+ gfx::Image google_image(*google_bitmap);
+
Time time;
GURL gurl;
- backend_->thumbnail_db_->SetPageThumbnail(gurl, row1_id, &google_bitmap,
+ backend_->thumbnail_db_->SetPageThumbnail(gurl, row1_id, &google_image,
score, time);
- gfx::Image weewar_bitmap(
+ scoped_ptr<SkBitmap> weewar_bitmap(
gfx::JPEGCodec::Decode(kWeewarThumbnail, sizeof(kWeewarThumbnail)));
- backend_->thumbnail_db_->SetPageThumbnail(gurl, row2_id, &weewar_bitmap,
+ gfx::Image weewar_image(*weewar_bitmap);
+ backend_->thumbnail_db_->SetPageThumbnail(gurl, row2_id, &weewar_image,
score, time);
// Star row1.
« no previous file with comments | « chrome/browser/history/expire_history_backend_unittest.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698