Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/image/image_util.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/image/image_unittest_util.h ('K') | « ui/gfx/image/image_unittest_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/image/image_util.cc
diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
index 42166293d25b9a338057c8d38bfd462d3e1e646b..ea870c0530ea581a071b58150aeb5292e66ad717 100644
--- a/ui/gfx/image/image_util.cc
+++ b/ui/gfx/image/image_util.cc
@@ -13,9 +13,9 @@
namespace gfx {
Image* ImageFromPNGEncodedData(const unsigned char* input, size_t input_size) {
- scoped_ptr<SkBitmap> favicon_bitmap(new SkBitmap());
- if (gfx::PNGCodec::Decode(input, input_size, favicon_bitmap.get()))
- return new Image(favicon_bitmap.release());
+ SkBitmap favicon_bitmap;
+ if (gfx::PNGCodec::Decode(input, input_size, &favicon_bitmap))
+ return new Image(favicon_bitmap);
return NULL;
}
« ui/gfx/image/image_unittest_util.h ('K') | « ui/gfx/image/image_unittest_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698