chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm - Issue 10378009: Get rid of Image::Image(SkBitmap*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

index 4c0197539fc1dd18edd7fb4a55668e9f00c91828..2daa7f1a1fa770abdaa84023bbf1f9185ad1040a 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

@@ -48,7 +48,7 @@ public:

SkBitmap bitmap = decoder.Decode(

reinterpret_cast<const unsigned char*>(file_contents.c_str()),

file_contents.length());

- icon_ = gfx::Image(new SkBitmap(bitmap));

+ icon_ = gfx::Image(bitmap);

}

void LoadExtension() {

« no previous file with comments | « chrome/browser/tab_contents/thumbnail_generator.cc ('k') | chrome/browser/ui/gtk/gtk_theme_service.h » ('j') | ui/gfx/image/image_unittest_util.h » ('J')