chrome/browser/profiles/gaia_info_update_service.cc - Issue 10378009: Get rid of Image::Image(SkBitmap*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/gaia_info_update_service.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/gaia_info_update_service.cc

diff --git a/chrome/browser/profiles/gaia_info_update_service.cc b/chrome/browser/profiles/gaia_info_update_service.cc

index f7ada7eedd57e16cb0f5358ef4476e33603983b8..32ce7cd39cfee1249c987589259fc1515a6176ed 100644

--- a/chrome/browser/profiles/gaia_info_update_service.cc

+++ b/chrome/browser/profiles/gaia_info_update_service.cc

@@ -129,7 +129,7 @@ void GAIAInfoUpdateService::OnDownloadComplete(ProfileDownloader* downloader,

if (picture_status == ProfileDownloader::PICTURE_SUCCESS) {

profile_->GetPrefs()->SetString(prefs::kProfileGAIAInfoPictureURL,

picture_url);

- gfx::Image gfx_image(new SkBitmap(bitmap));

+ gfx::Image gfx_image(bitmap);

cache.SetGAIAPictureOfProfileAtIndex(profile_index, &gfx_image);

} else if (picture_status == ProfileDownloader::PICTURE_DEFAULT) {

cache.SetGAIAPictureOfProfileAtIndex(profile_index, NULL);