Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/mac/keychain_reauthorize.mm

Issue 10377173: Do Keychain reauthorization at update time (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/mac/keychain_reauthorize.mm
===================================================================
--- chrome/browser/mac/keychain_reauthorize.mm (revision 137420)
+++ chrome/browser/mac/keychain_reauthorize.mm (working copy)
@@ -128,7 +128,12 @@
if (pref_value < max_tries) {
if (pref_value > 0) {
// Logs the number of previous tries that didn't complete.
- UMA_HISTOGRAM_COUNTS("OSX.KeychainReauthorizeIfNeeded", pref_value);
+ if (base::mac::AmIBundled()) {
+ UMA_HISTOGRAM_COUNTS("OSX.KeychainReauthorizeIfNeeded", pref_value);
+ } else {
+ UMA_HISTOGRAM_COUNTS("OSX.KeychainReauthorizeIfNeededAtUpdate",
+ pref_value);
+ }
}
++pref_value;
@@ -143,7 +148,13 @@
[user_defaults synchronize];
// Logs the try number (1, 2) that succeeded.
- UMA_HISTOGRAM_COUNTS("OSX.KeychainReauthorizeIfNeededSuccess", pref_value);
+ if (base::mac::AmIBundled()) {
+ UMA_HISTOGRAM_COUNTS("OSX.KeychainReauthorizeIfNeededSuccess",
+ pref_value);
+ } else {
+ UMA_HISTOGRAM_COUNTS("OSX.KeychainReauthorizeIfNeededAtUpdateSuccess",
+ pref_value);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698