Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4547)

Unified Diff: chrome/app/breakpad_mac.mm

Issue 10377173: Do Keychain reauthorization at update time (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_mac.mm » ('j') | chrome/browser/chrome_browser_main_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/breakpad_mac.mm
===================================================================
--- chrome/app/breakpad_mac.mm (revision 137420)
+++ chrome/app/breakpad_mac.mm (working copy)
@@ -187,6 +187,11 @@
NSString *reporter_location =
[[NSBundle bundleWithPath:reporter_bundle_location] executablePath];
+ if (!inspector_location || !reporter_location) {
+ VLOG_IF(1, is_browser && base::mac::AmIBundled()) << "Breakpad disabled";
+ return;
+ }
+
NSDictionary* info_dictionary = [main_bundle infoDictionary];
NSMutableDictionary *breakpad_config =
[[info_dictionary mutableCopy] autorelease];
@@ -231,7 +236,7 @@
// Initialize Breakpad.
gBreakpadRef = BreakpadCreate(breakpad_config);
if (!gBreakpadRef) {
- LOG(ERROR) << "Breakpad initializaiton failed";
+ LOG_IF(ERROR, base::mac::AmIBundled()) << "Breakpad initializaiton failed";
return;
}
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_mac.mm » ('j') | chrome/browser/chrome_browser_main_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698